Repository navigation
fix(blob): support legacy Python CRCs and configurable verification - #1467
Draft
XiaoHongbo-Hope wants to merge 1 commit into
Draft
XiaoHongbo-Hope wants to merge 1 commit into
XiaoHongbo-Hope wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Closes #1466. Intact BLOB files written by Python before apache/paimon#9426 fail Rust reads because their CRC excludes the trailing entry length.
Brief change log
blob.read.verify-crc(defaulttrue) to scalar/array/map BLOB reads, including Data Evolution fallback reads.falseskips CRC calculation only; magic, length and range checks remain enabled.Tests
Historical Python-generated scalar/array/map fixtures, mixed standard/legacy entries, empty/null entries, corruption rejection, option parsing, and disabled verification through format-reader and Data Evolution paths.
cargo test -p paimon --lib blob --locked: 275 passed.cargo fmt --all -- --checkandgit diff --check: passed.cargo clippy -p paimon --lib --locked -- -D warnings: passed.API and Format
New optional read setting; no writer or on-disk format changes. Disabling CRC means payload corruption detectable only by the checksum is no longer rejected. This setting does not control external-object or Python-side descriptor fetching.
Documentation
Added the option and its scope to the Python binding guide.