Repository navigation
[flink][spark] Fix create_tag ignoring the table's default retention - #11294
Open
danzhewuju wants to merge 1 commit into
Open
danzhewuju wants to merge 1 commit into
danzhewuju wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fixes #11293.
Scheduled jobs commonly set
tag.default-time-retainedon the table and omittime_retainedinCALL ...create_tag. The procedure forwarded a null duration, so the tag was written without a retention period. Regular TTL cleanup skips those tags, allowing historical snapshots and their data files to accumulate.Use the existing
Table.createTagoverloads that apply the table default whentime_retainedis omitted. This covers both the latest snapshot and a specified snapshot in the shared Flink procedure, the Flink 1.18 procedure, and the shared Spark procedure. An explicit duration still overrides the table default.Tests