Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow-up to #10748, which fixed schema selection for branch time travel. With no snapshot or tag selector,
main.copy({"branch": "dev"})could still read data fromdevusing the fields frommain. In a Parquet table where onlydevwidenedcountfrom INT to BIGINT, a stored value of3000000000came back as-1294967296. A column added ondevwas also missing from the result. Original discussionWhen a copy switches branches for a latest read, it now loads the target branch's schema and reapplies the caller's explicit option overrides and removals. REST tables use the catalog response for the selected branch. Snapshot and tag reads continue to use their historical schemas.
Tests
All four new regression cases failed on
7a30ef580eand passed with the fix. They cover reading the widened value, a schema change with no new snapshot, writes through the branch copy, option overrides, and REST metadata for managed and external tables.On Windows with Python 3.10.11 and PyArrow 19.0.1, all 191 tests in the ten targeted files passed on rerun. The first run had one intermittent failure in
test_rename_branch_basic. In isolation it hit Windows error 5 once in eight runs on both the base and patched code. Flake8 passed for both changed Python files.