Repository navigation
[flink] Implement FLIP-314 LineageVertexProvider for non-table source & sink APIs #8001
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JingsongLi
merged 11 commits into
apache:master
from
jsinghkukreja:add-lineage-for-non-table-apis
Jul 1, 2026
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
202acc6
[flink] Implement FLIP-314 LineageVertexProvider for non-table APIs
jsinghkukreja fa3f15b
Trigger CI
jsinghkukreja d88cdc0
Merge branch 'master' into add-lineage-for-non-table-apis
jsinghkukreja 7648e15
Merge branch 'apache:master' into add-lineage-for-non-table-apis
jsinghkukreja df4d29e
Re-Trigger CI
jsinghkukreja 39704ef
Merge branch 'apache:master' into add-lineage-for-non-table-apis
jsinghkukreja 8b6a41e
Merge branch 'apache:master' into add-lineage-for-non-table-apis
jsinghkukreja 0b77c2a
Merge branch 'apache:master' into add-lineage-for-non-table-apis
jsinghkukreja 57f2fb5
flink: only add core-options and metadata prefix config options to th…
jsinghkukreja c17f1eb
flink: only add metadata iceberg config options explicitly
jsinghkukreja a342d47
flink: avoid over-riding table api lineage name
jsinghkukreja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
.../paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/PaimonDiscardingSink.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.paimon.flink.sink; | ||
|
|
||
| import org.apache.paimon.flink.lineage.LineageUtils; | ||
| import org.apache.paimon.table.FileStoreTable; | ||
|
|
||
| import org.apache.flink.streaming.api.functions.sink.v2.DiscardingSink; | ||
| import org.apache.flink.streaming.api.lineage.LineageVertex; | ||
| import org.apache.flink.streaming.api.lineage.LineageVertexProvider; | ||
|
|
||
| /** | ||
| * A {@link DiscardingSink} that implements {@link LineageVertexProvider} so Flink's lineage graph | ||
| * discovers the Paimon sink table when using the DataStream API. | ||
| */ | ||
| public class PaimonDiscardingSink<T> extends DiscardingSink<T> implements LineageVertexProvider { | ||
|
|
||
| private static final long serialVersionUID = 1L; | ||
|
|
||
| private final FileStoreTable table; | ||
|
|
||
| public PaimonDiscardingSink(FileStoreTable table) { | ||
| this.table = table; | ||
| } | ||
|
|
||
| @Override | ||
| public LineageVertex getLineageVertex() { | ||
| return LineageUtils.sinkLineageVertex(table); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also changes the existing table/SQL lineage path.
PaimonDataStreamScanProviderandPaimonDataStreamSinkProviderpass the FlinktableIdentifier.asSummaryString()as an explicit name, but for JDBC catalogs this branch ignores it and emitscatalog-key + "." + table.fullName()instead, while non-JDBC catalogs keep the Flink identifier. That makes table/SQL dataset names metastore-dependent even though the new derivation is only needed when the non-table DataStream APIs do not have a name. Please keepdefaultNamewhen it is non-null, and only derive the catalog-key name when no explicit name was provided; a JDBC-metastore regression for the explicit-name overload would catch this.Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JingsongLi This is by design, the
catalog-keyoverride for JDBC metastore on the Table API path is intentional. Catalog names which is used intableIdentifier.asSummaryString()are arbitrary per-job the same physical table can appear under different lineage dataset names depending on how the job defines its catalog name.catalog-keyis a more stable cross-job identifier that users can explicitly configure. This is particularly valuable when the same database and table exist across different catalogs thecatalog-keydisambiguates them.For context, this is the follow up ticket to support this in Flink: https://issues.apache.org/jira/browse/FLINK-39935
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the context. I still think the explicit
defaultNameshould win in this overload. The Table/SQL providers pass the resolved Flink table identifier here, so overriding it only for JDBC catalogs changes the existing table/SQL lineage name even though the catalog-key derivation is only needed for the new DataStream APIs where no name is available. That makes the same SQL/table job report a different dataset name after switching the catalog metastore/config, which is a surprising behavior change for this PR. Please keepdefaultNamewhen it is non-null and usecatalog-key + "." + table.fullName()only for the null-name DataStream overload (or split the Table/SQL naming change into a separate documented change with compatibility discussion and tests).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JingsongLi Makes sense, i have added the fix as suggested. I can create a separate PR with reasoning for the table/sql flow.