Skip to content

[spark] Fix batch delete for partial update sequence groups #9546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArnavBalyan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[spark] Fix batch delete for partial update sequence groups #9546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...common/src/main/scala/org/apache/paimon/spark/commands/DeleteFromPaimonTableCommand.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

package org.apache.paimon.spark.commands

import org.apache.paimon.Snapshot
import org.apache.paimon.{CoreOptions, Snapshot}
import org.apache.paimon.spark.catalyst.analysis.expressions.ExpressionHelper
import org.apache.paimon.spark.schema.SparkSystemColumns.ROW_KIND_COL
import org.apache.paimon.table.FileStoreTable
Expand Down Expand Up @@ -54,7 +54,8 @@ case class DeleteFromPaimonTableCommand(
private def usePKUpsertDelete(): Boolean = {
try {
validatePKUpsertDeletable(table)
true
coreOptions.mergeEngine() != CoreOptions.MergeEngine.PARTIAL_UPDATE ||
coreOptions.toConfiguration.get(CoreOptions.PARTIAL_UPDATE_REMOVE_RECORD_ON_DELETE)
} catch {
case _: UnsupportedOperationException => false
}
Expand Down
17 changes: 17 additions & 0 deletions .../paimon-spark-ut/src/test/scala/org/apache/paimon/spark/sql/DeleteFromTableTestBase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,23 @@ abstract class DeleteFromTableTestBase extends PaimonSparkTestBase {
}
}

test("Paimon Delete: partial update with remove record on sequence group") {
spark.sql(s"""
|CREATE TABLE T (id INT, g INT, v BIGINT)
|TBLPROPERTIES (
| 'primary-key' = 'id',
| 'bucket' = '2',
| 'merge-engine' = 'partial-update',
| 'fields.g.sequence-group' = 'v',
| 'partial-update.remove-record-on-sequence-group' = 'g')
|""".stripMargin)

spark.sql("INSERT INTO T VALUES (1, 1, 10), (2, 1, 20)")
spark.sql("DELETE FROM T WHERE id = 1")

checkAnswer(spark.sql("SELECT * FROM T"), Row(2, 1, 20L))
}

test("Paimon delete: non pk table commit kind") {
for (dvEnabled <- Seq(true, false)) {
withTable("t") {
Expand Down
Loading