Repository navigation
GH-3289: Test conversion and writer configuration through CLI - #3861
Open
zhangxinyao88 wants to merge 1 commit into
Open
zhangxinyao88 wants to merge 1 commit into
zhangxinyao88 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Continue #3289 with
convert/to-avrocoverage and observable writer configuration checks. Existing command tests largely assign fields directly and check file existence. Configuration-loading tests do not establish that a setting changes the resulting file.What changes are included in this PR?
Add fourteen cases using deterministic Avro and Parquet inputs:
--overwriteand replaced by readable records with it.--propertyand properties/XML configuration files change a UUID field from string storage to 16-byte UUID storage in the Parquet footer.Assertions read records, codec metadata and physical/logical schema types. Paths contain spaces; no help-text or full-log snapshots are added. Read, inspection and CSV scopes in #3858/#3859/#3860 remain separate.
Are these changes tested?
./mvnw -o -B -ntp -pl parquet-cli spotless:check test: 97 cases, 95 passed, 2 skipped, no failures/errors. All fourteen new cases passed; Spotless and RAT checks passed. Java 17 and cached dependencies were used; no full-reactor or multi-JDK build was run.Eleven temporary local regression controls triggered assertion failures when projection, supplied schemas, codecs, overwrite or configuration propagation/precedence was ignored. All production edits were restored before the successful module run.
Are there any user-facing changes?
No. Tests only.