[fix][test] Avoid blocking common-pool workers in ledger shutdown test - #26560
Open
lhotari wants to merge 1 commit into
Open
[fix][test] Avoid blocking common-pool workers in ledger shutdown test#26560lhotari wants to merge 1 commit into
lhotari wants to merge 1 commit into
Conversation
lhotari
requested review from
Technoboy-,
dao-jun,
david-streamlio,
merlimat and
nodece
September 12, 2026 21:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
ManagedLedgerFactoryShutdownTest.openEncounteredShutdowndelays metadata reads by blocking common-pool workers on a latch. Shutdown also schedules completion on that pool, so a small common pool can stall before the test releases the latch.Modifications
Gate the mocked metadata reads with a
CompletableFuturecreated for each test invocation. Complete the gate after shutdown, preserving the late-read scenario and callback assertions without occupying workers while waiting.Verifying this change
Verified
ManagedLedgerFactoryShutdownTest.openEncounteredShutdownlocally with temporaryinvocationCount = 10: 10/10 passed with retries disabled. With common-pool parallelism set to 2, the original test times out after 5 seconds and the fixed test passes 10/10 invocations. The temporary invocation count was removed../gradlew spotlessCheck checkstyleMain checkstyleTestpassed.Does this pull request potentially affect one of the following parts: