[fix][test] Await both DLQ producers in multi-consumer test - #26561
Open
lhotari wants to merge 1 commit into
Open
[fix][test] Await both DLQ producers in multi-consumer test#26561lhotari wants to merge 1 commit into
lhotari wants to merge 1 commit into
Conversation
lhotari
requested review from
Technoboy-,
dao-jun,
david-streamlio,
merlimat and
nodece
September 12, 2026 21:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
testDeadLetterTopicWithInitialSubscriptionAndMultiConsumerswaits for the dead-letter topic and initial subscription to exist, then immediately asserts that both consumers have a DLQ producer. Each consumer creates its producer asynchronously, so the second producer can still be pending when the topic and subscription are visible.Modifications
Include the exact two-producer assertion in the existing bounded Awaitility check. The test still verifies that both consumers can create DLQ producers and that all messages reach the dead-letter topic.
Verifying this change
Verified
DeadLetterTopicTest.testDeadLetterTopicWithInitialSubscriptionAndMultiConsumerslocally with temporaryinvocationCount = 10: 10/10 passed with retries disabled. The temporary invocation count was removed../gradlew spotlessCheck checkstyleMain checkstyleTestpassed.Does this pull request potentially affect one of the following parts: