Skip to content

[fix][test] Await both DLQ producers in multi-consumer test - #26561

Open
lhotari wants to merge 1 commit into
apache:masterfrom
lhotari:lh-fix-dlq-producer-test
Open

[fix][test] Await both DLQ producers in multi-consumer test#26561
lhotari wants to merge 1 commit into
apache:masterfrom
lhotari:lh-fix-dlq-producer-test

Conversation

@lhotari

@lhotari lhotari commented Sep 12, 2026

Copy link
Copy Markdown
Member

Motivation

testDeadLetterTopicWithInitialSubscriptionAndMultiConsumers waits for the dead-letter topic and initial subscription to exist, then immediately asserts that both consumers have a DLQ producer. Each consumer creates its producer asynchronously, so the second producer can still be pending when the topic and subscription are visible.

Modifications

Include the exact two-producer assertion in the existing bounded Awaitility check. The test still verifies that both consumers can create DLQ producers and that all messages reach the dead-letter topic.

Verifying this change

  • Make sure that the change passes the CI checks.

Verified DeadLetterTopicTest.testDeadLetterTopicWithInitialSubscriptionAndMultiConsumers locally with temporary invocationCount = 10: 10/10 passed with retries disabled. The temporary invocation count was removed.

./gradlew spotlessCheck checkstyleMain checkstyleTest passed.

Does this pull request potentially affect one of the following parts:

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

@void-ptr974 void-ptr974 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants