Skip to content

Keep it-playwright on the project version and let bump-version.sh run on master - #287

Merged
mraible merged 1 commit into
apache:masterfrom
mraible:release-version-bookkeeping
Nov 16, 2026
Merged

mraible merged 1 commit into
apache:masterfrom
mraible:release-version-bookkeeping

Conversation

@mraible

@mraible mraible commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Two version-bookkeeping fixes found while cutting 7.0.0 RC1.

  • skills/roller-release/scripts/bump-version.sh required it-selenium/pom.xml, which only roller-6.1.x has, so on master it stopped with "Missing expected files" and Set version to 7.0.0 #284's edits were made by hand. It now requires the four main POMs, updates it-selenium or it-playwright when present, and also updates the roller.version property in the root POM, which it skipped before.
  • it-playwright/pom.xml still said 6.1.6. It's a separate project outside the reactor, but it ships in the source archive, so it now follows the project version (7.0.0-SNAPSHOT).

Dry runs: on master, 7.0.0 7.0.0-SNAPSHOT finds the same 7 values #284 changed by hand; on roller-6.1.x, 6.1.8 6.1.9-SNAPSHOT finds the main POMs and it-selenium.

… on master

bump-version.sh required it-selenium/pom.xml, which only roller-6.1.x has, so it refused to run on master, and it skipped the roller.version property in the root POM. It now treats it-selenium and it-playwright as optional and updates roller.version too. it-playwright's own version was still 6.1.6.
@mraible
mraible requested a review from snoopdave November 16, 2026 01:22

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraible mraible closed this Nov 16, 2026
@mraible
mraible deleted the release-version-bookkeeping branch November 16, 2026 01:52
@mraible
mraible restored the release-version-bookkeeping branch November 16, 2026 01:52
@mraible mraible reopened this Nov 16, 2026
@mraible
mraible merged commit 5fda875 into apache:master Nov 16, 2026
22 of 23 checks passed
@mraible
mraible deleted the release-version-bookkeeping branch November 16, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants