Repository navigation
Keep it-playwright on the project version and let bump-version.sh run on master - #287
Merged
Merged
Conversation
… on master bump-version.sh required it-selenium/pom.xml, which only roller-6.1.x has, so it refused to run on master, and it skipped the roller.version property in the root POM. It now treats it-selenium and it-playwright as optional and updates roller.version too. it-playwright's own version was still 6.1.6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two version-bookkeeping fixes found while cutting 7.0.0 RC1.
skills/roller-release/scripts/bump-version.shrequiredit-selenium/pom.xml, which only roller-6.1.x has, so on master it stopped with "Missing expected files" and Set version to 7.0.0 #284's edits were made by hand. It now requires the four main POMs, updatesit-seleniumorit-playwrightwhen present, and also updates theroller.versionproperty in the root POM, which it skipped before.it-playwright/pom.xmlstill said 6.1.6. It's a separate project outside the reactor, but it ships in the source archive, so it now follows the project version (7.0.0-SNAPSHOT).Dry runs: on master,
7.0.0 7.0.0-SNAPSHOTfinds the same 7 values #284 changed by hand; on roller-6.1.x,6.1.8 6.1.9-SNAPSHOTfinds the main POMs andit-selenium.