Repository navigation
Keep the Emoticons plugin out of HTML tags and comments - #290
Merged
Merged
Conversation
The plugin replaced emoticons anywhere in an entry, so the :x in xmlns:xlink inside an embedded SVG became an emoji. The single-pass pattern now also matches tags and comments and copies them unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Emoticons plugin replaced emoticons anywhere in an entry's HTML, including inside tags. On a copy of raibledesigns.com, nine posts with Instagram embeds have an SVG with
xmlns:xlink=..., and its:xbecame an emoji, breaking the markup. Roller 5 broke the same spot with a GIF, so this isn't a regression from #266, but it's still wrong.SmileysPlugin's single-pass pattern now also matches an HTML comment or tag (<followed by a letter,/or!, up to>) and copies it unchanged, so only text between tags is replaced.<in text, as in1 < 2 :-), isn't treated as a tag, so the emoticon after it still converts.SmileysPluginTestcovers the SVG case, an attribute holding:-), a comment, and the<case; the SVG test fails without the fix.