Skip to content

Use the standard ASF license header - #291

Merged
mraible merged 1 commit into
apache:masterfrom
mraible:standard-license-headers
Nov 16, 2026
Merged

mraible merged 1 commit into
apache:masterfrom
mraible:standard-license-headers

Conversation

@mraible

@mraible mraible commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Replaces the older ASF license header with the standard one in the 929 tracked files that had it. Only comments change.

The old text goes straight from "contributor license agreements" to "The ASF licenses this file to You" and ends with "For additional information regarding copyright in this work, please see the NOTICE file in the top level directory of this distribution". RAT accepts it, but Apache Trusted Releases checks for the standard wording and reported 716 header concerns on the 7.0.0 RC1 source archive (it only checks some file types; the other files are changed too so every header matches).

  • 925 files were rewritten by a script that keeps each file's comment style (/* * */, <%-- --%>, <!-- -->, #**, #, -- and so on).
  • The Hyde, PaperMod and Terminal theme.xml files and InstallTest.java had a shortened one- or few-line header and now have the full one.
  • Checked with ATR's own matching rule: no tracked file has an ASF header ATR would reject.
  • mvn apache-rat:check passes, and mvn clean install passes (729 tests, no failures).

No CHANGES entry, since nothing user-facing changes.

Most files had an older form of the ASF header, which goes straight from "contributor license agreements" to "The ASF licenses this file to You" and ends by pointing to the NOTICE file in the top level directory. Apache Trusted Releases only accepts the current standard header, so it reported 716 header concerns on the 7.0.0 RC1 source archive. This replaces the old text in each comment style, and gives the full header to the three new themes' theme.xml files and InstallTest.java, which had a shortened one.
@mraible
mraible requested a review from snoopdave November 16, 2026 01:27
@mraible

mraible commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

The CodeQL check fails only because this PR touches files that already have open code scanning alerts on master. All 11 it lists are existing master alerts with the same rule and location, one line lower because the standard header is one line longer. CodeQL's own summary notes it may report pre-existing alerts when a change is this large. Both CodeQL analyses, the build, the UI tests and the license header check pass.

@snoopdave snoopdave left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this changes only comment code so +1

@mraible

mraible commented Nov 16, 2026

Copy link
Copy Markdown
Contributor Author

That's right, only comments change. I checked every file in the PR: with the license header block removed, all 929 are identical to master. In 925 the old header text is replaced in place. The Hyde, PaperMod and Terminal theme.xml files and InstallTest.java get the full header in a new comment block, replacing their shortened one. Thanks for the review!

@mraible
mraible merged commit dac1743 into apache:master Nov 16, 2026
8 of 9 checks passed
@mraible
mraible deleted the standard-license-headers branch November 16, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants