Repository navigation
Use the standard ASF license header - #291
Conversation
Most files had an older form of the ASF header, which goes straight from "contributor license agreements" to "The ASF licenses this file to You" and ends by pointing to the NOTICE file in the top level directory. Apache Trusted Releases only accepts the current standard header, so it reported 716 header concerns on the 7.0.0 RC1 source archive. This replaces the old text in each comment style, and gives the full header to the three new themes' theme.xml files and InstallTest.java, which had a shortened one.
|
The CodeQL check fails only because this PR touches files that already have open code scanning alerts on master. All 11 it lists are existing master alerts with the same rule and location, one line lower because the standard header is one line longer. CodeQL's own summary notes it may report pre-existing alerts when a change is this large. Both CodeQL analyses, the build, the UI tests and the license header check pass. |
snoopdave
left a comment
There was a problem hiding this comment.
I believe this changes only comment code so +1
|
That's right, only comments change. I checked every file in the PR: with the license header block removed, all 929 are identical to master. In 925 the old header text is replaced in place. The Hyde, PaperMod and Terminal theme.xml files and InstallTest.java get the full header in a new comment block, replacing their shortened one. Thanks for the review! |
Replaces the older ASF license header with the standard one in the 929 tracked files that had it. Only comments change.
The old text goes straight from "contributor license agreements" to "The ASF licenses this file to You" and ends with "For additional information regarding copyright in this work, please see the NOTICE file in the top level directory of this distribution". RAT accepts it, but Apache Trusted Releases checks for the standard wording and reported 716 header concerns on the 7.0.0 RC1 source archive (it only checks some file types; the other files are changed too so every header matches).
/* * */,<%-- --%>,<!-- -->,#**,#,--and so on).theme.xmlfiles andInstallTest.javahad a shortened one- or few-line header and now have the full one.mvn apache-rat:checkpasses, andmvn clean installpasses (729 tests, no failures).No CHANGES entry, since nothing user-facing changes.