Repository navigation
SOLR-17665: Avoid search executor overhead when multiThreaded=false - #5273
Draft
arup-chauhan wants to merge 1 commit into
Draft
arup-chauhan wants to merge 1 commit into
arup-chauhan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on: SOLR-17665
Description
This draft investigates search executor overhead when
multiThreaded=false.The current patch prepares the benchmark. Reproducing the regression and implementing a fix remain pending.
Changes so far
indexSearcherExecutorThreadsexplicitly in the benchmark cluster.multiThreadedflag independently.The comparison uses three cases: pool disabled, pool enabled with
multiThreaded=false, and pool enabled withmultiThreaded=true.Next, measure the pool's overhead with
multiThreaded=falseand profile any slowdown. Those results will guide whether request-level executor isolation is needed.Validation
tidypassed../gradlew --no-daemon check -x testandupdateLicensespassed.These runs verify the setup. They do not establish performance results. The full unit-test suite has not been run.
Code and PR description generated with OpenAI Codex and personally reviewed by me.