Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions storm-client/src/jvm/org/apache/storm/Config.java
Original file line number Diff line number Diff line change
Expand Up @@ -1420,7 +1420,7 @@ public class Config extends HashMap<String, Object> {
* to Nimbus) instead.
*/
@IsStringList
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public static final String PACEMAKER_SERVERS = "pacemaker.servers";
/**
* The port Pacemaker should run on. Clients should connect to this port to submit or read
Expand All @@ -1433,7 +1433,7 @@ public class Config extends HashMap<String, Object> {
*/
@IsNumber
@IsPositiveNumber
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public static final String PACEMAKER_PORT = "pacemaker.port";
/**
* The maximum number of threads that should be used by the Pacemaker client.
Expand All @@ -1447,7 +1447,7 @@ public class Config extends HashMap<String, Object> {
*/
@IsNumber
@IsPositiveNumber
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public static final String PACEMAKER_CLIENT_MAX_THREADS = "pacemaker.client.max.threads";
/**
* This should be one of "DIGEST", "KERBEROS", or "NONE" Determines the mode of authentication
Expand All @@ -1464,7 +1464,7 @@ public class Config extends HashMap<String, Object> {
* to Nimbus) instead.
*/
@CustomValidator(validatorClass = ConfigValidation.PacemakerAuthTypeValidator.class)
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public static final String PACEMAKER_AUTH_METHOD = "pacemaker.auth.method";
/**
* Pacemaker Thrift Max Message Size (bytes).
Expand All @@ -1476,7 +1476,7 @@ public class Config extends HashMap<String, Object> {
*/
@IsInteger
@IsPositiveNumber
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public static final String PACEMAKER_THRIFT_MESSAGE_SIZE_MAX =
"pacemaker.thrift.message.size.max";
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,15 @@
* them to Nimbus over
* Thrift, with the default ZooKeeper-based cluster state store ({@code org.apache.storm.cluster.ZKStateStorageFactory}).
*/
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public class PaceMakerStateStorage implements IStateStorage {

private static final int maxRetries = 10;
private static Logger LOG = LoggerFactory.getLogger(PaceMakerStateStorage.class);
private PacemakerClientPool pacemakerClientPool;

Check warning on line 54 in storm-client/src/jvm/org/apache/storm/cluster/PaceMakerStateStorage.java

View workflow job for this annotation

GitHub Actions / test (25, Client, false)

org.apache.storm.pacemaker.PacemakerClientPool in org.apache.storm.pacemaker has been deprecated and marked for removal
private IStateStorage stateStorage;

public PaceMakerStateStorage(PacemakerClientPool pacemakerClientPool,

Check warning on line 57 in storm-client/src/jvm/org/apache/storm/cluster/PaceMakerStateStorage.java

View workflow job for this annotation

GitHub Actions / test (25, Client, false)

org.apache.storm.pacemaker.PacemakerClientPool in org.apache.storm.pacemaker has been deprecated and marked for removal
IStateStorage stateStorage) throws Exception {
this.pacemakerClientPool = pacemakerClientPool;
this.stateStorage = stateStorage;
Expand Down Expand Up @@ -142,7 +142,7 @@
}
LOG.debug("Successful set_worker_hb");
break;
} catch (HBExecutionException | PacemakerConnectionException e) {

Check warning on line 145 in storm-client/src/jvm/org/apache/storm/cluster/PaceMakerStateStorage.java

View workflow job for this annotation

GitHub Actions / test (25, Client, false)

org.apache.storm.pacemaker.PacemakerConnectionException in org.apache.storm.pacemaker has been deprecated and marked for removal
if (retry <= 0) {
throw new RuntimeException(e);
}
Expand Down Expand Up @@ -190,7 +190,7 @@
throw new WrappedHBExecutionException("Failed to get a response.");
}
return ret;
} catch (HBExecutionException | PacemakerConnectionException e) {

Check warning on line 193 in storm-client/src/jvm/org/apache/storm/cluster/PaceMakerStateStorage.java

View workflow job for this annotation

GitHub Actions / test (25, Client, false)

org.apache.storm.pacemaker.PacemakerConnectionException in org.apache.storm.pacemaker has been deprecated and marked for removal
if (retry <= 0) {
throw new RuntimeException(e);
}
Expand Down Expand Up @@ -227,7 +227,7 @@

LOG.debug("Successful get_worker_hb_children");
return new ArrayList<>(retSet);
} catch (PacemakerConnectionException e) {

Check warning on line 230 in storm-client/src/jvm/org/apache/storm/cluster/PaceMakerStateStorage.java

View workflow job for this annotation

GitHub Actions / test (25, Client, false)

org.apache.storm.pacemaker.PacemakerConnectionException in org.apache.storm.pacemaker has been deprecated and marked for removal
if (retry <= 0) {
throw new RuntimeException(e);
}
Expand Down Expand Up @@ -265,7 +265,7 @@
} else {
throw new WrappedHBExecutionException("Failed to delete from all pacemakers.");
}
} catch (HBExecutionException | PacemakerConnectionException e) {

Check warning on line 268 in storm-client/src/jvm/org/apache/storm/cluster/PaceMakerStateStorage.java

View workflow job for this annotation

GitHub Actions / test (25, Client, false)

org.apache.storm.pacemaker.PacemakerConnectionException in org.apache.storm.pacemaker has been deprecated and marked for removal
if (retry <= 0) {
if (someSucceeded) {
LOG.warn("Unable to delete_worker_hb from every pacemaker.");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
* them to Nimbus over
* Thrift, with the default ZooKeeper-based cluster state store ({@code org.apache.storm.cluster.ZKStateStorageFactory}).
*/
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public class PaceMakerStateStorageFactory implements StateStorageFactory {
@Override
public IStateStorage mkStore(Map<String, Object> config, Map<String, Object> authConf,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
* them to Nimbus over
* Thrift, with the default ZooKeeper-based cluster state store ({@code org.apache.storm.cluster.ZKStateStorageFactory}).
*/
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public class PacemakerClient implements ISaslClient {

private static final Logger LOG = LoggerFactory.getLogger(PacemakerClient.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
* them to Nimbus over
* Thrift, with the default ZooKeeper-based cluster state store ({@code org.apache.storm.cluster.ZKStateStorageFactory}).
*/
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public class PacemakerClientHandler extends ChannelInboundHandlerAdapter {
private static final Logger LOG = LoggerFactory.getLogger(PacemakerClientHandler.class);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
* them to Nimbus over
* Thrift, with the default ZooKeeper-based cluster state store ({@code org.apache.storm.cluster.ZKStateStorageFactory}).
*/
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public class PacemakerClientPool {

private static final Logger LOG = LoggerFactory.getLogger(PacemakerClientPool.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
* them to Nimbus over
* Thrift, with the default ZooKeeper-based cluster state store ({@code org.apache.storm.cluster.ZKStateStorageFactory}).
*/
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public class PacemakerConnectionException extends Exception {
public PacemakerConnectionException(String err) {
super(err);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
* them to Nimbus over
* Thrift, with the default ZooKeeper-based cluster state store ({@code org.apache.storm.cluster.ZKStateStorageFactory}).
*/
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public class ThriftDecoder extends ByteToMessageDecoder {

private static final Logger LOG = LoggerFactory.getLogger(ThriftDecoder.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
* them to Nimbus over
* Thrift, with the default ZooKeeper-based cluster state store ({@code org.apache.storm.cluster.ZKStateStorageFactory}).
*/
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public class ThriftEncoder extends MessageToMessageEncoder<Object> {

private static final Logger LOG = LoggerFactory
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
* them to Nimbus over
* Thrift, with the default ZooKeeper-based cluster state store ({@code org.apache.storm.cluster.ZKStateStorageFactory}).
*/
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public class ThriftNettyClientCodec extends ChannelInitializer<Channel> {

public static final String SASL_HANDLER = "sasl-handler";
Expand Down
4 changes: 2 additions & 2 deletions storm-server/src/main/java/org/apache/storm/DaemonConfig.java
Original file line number Diff line number Diff line change
Expand Up @@ -676,7 +676,7 @@ public class DaemonConfig implements Validated {
*/
@IsNumber
@IsPositiveNumber
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public static final String PACEMAKER_MAX_THREADS = "pacemaker.max.threads";

/**
Expand All @@ -686,7 +686,7 @@ public class DaemonConfig implements Validated {
* Use the default heartbeat path (workers heartbeat to their supervisor, which reports them to Nimbus) instead.
*/
@IsStringOrStringList
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public static final String PACEMAKER_CHILDOPTS = "pacemaker.childopts";


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
* Use the default heartbeat path instead: workers heartbeat to their supervisor, which reports them to Nimbus over
* Thrift, with the default ZooKeeper-based cluster state store ({@code org.apache.storm.cluster.ZKStateStorageFactory}).
*/
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public interface IServerMessageHandler {

HBMessage handleMessage(HBMessage m, boolean authenticated);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@
* Use the default heartbeat path instead: workers heartbeat to their supervisor, which reports them to Nimbus over
* Thrift, with the default ZooKeeper-based cluster state store ({@code org.apache.storm.cluster.ZKStateStorageFactory}).
*/
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public class Pacemaker implements IServerMessageHandler {

Check warning on line 44 in storm-server/src/main/java/org/apache/storm/pacemaker/Pacemaker.java

View workflow job for this annotation

GitHub Actions / test (25, Server, false)

org.apache.storm.pacemaker.IServerMessageHandler in org.apache.storm.pacemaker has been deprecated and marked for removal

private static final Logger LOG = LoggerFactory.getLogger(Pacemaker.class);
private final Meter meterSendPulseCount;
Expand Down Expand Up @@ -209,9 +209,9 @@
return new HBMessage(HBServerMessageType.DELETE_PULSE_ID_RESPONSE, null);
}

private PacemakerServer launchServer() {

Check warning on line 212 in storm-server/src/main/java/org/apache/storm/pacemaker/Pacemaker.java

View workflow job for this annotation

GitHub Actions / test (25, Server, false)

org.apache.storm.pacemaker.PacemakerServer in org.apache.storm.pacemaker has been deprecated and marked for removal
LOG.info("Starting pacemaker server for storm version '{}", VersionInfo.getVersion());
return new PacemakerServer(this, conf);

Check warning on line 214 in storm-server/src/main/java/org/apache/storm/pacemaker/Pacemaker.java

View workflow job for this annotation

GitHub Actions / test (25, Server, false)

org.apache.storm.pacemaker.PacemakerServer in org.apache.storm.pacemaker has been deprecated and marked for removal
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -45,24 +45,24 @@
* Use the default heartbeat path instead: workers heartbeat to their supervisor, which reports them to Nimbus over
* Thrift, with the default ZooKeeper-based cluster state store ({@code org.apache.storm.cluster.ZKStateStorageFactory}).
*/
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
class PacemakerServer implements ISaslServer {

private static final int FIVE_MB_IN_BYTES = 5 * 1024 * 1024;

private static final Logger LOG = LoggerFactory.getLogger(PacemakerServer.class);

private final IServerMessageHandler handler;

Check warning on line 55 in storm-server/src/main/java/org/apache/storm/pacemaker/PacemakerServer.java

View workflow job for this annotation

GitHub Actions / test (25, Server, false)

org.apache.storm.pacemaker.IServerMessageHandler in org.apache.storm.pacemaker has been deprecated and marked for removal
private String secret;
private final String topologyName;
private volatile ChannelGroup allChannels = new DefaultChannelGroup("storm-server", GlobalEventExecutor.INSTANCE);
private final ChannelGroup authenticatedChannels = new DefaultChannelGroup("authenticated-pacemaker-channels",
GlobalEventExecutor.INSTANCE);
private final ThriftNettyServerCodec.AuthMethod authMethod;

Check warning on line 61 in storm-server/src/main/java/org/apache/storm/pacemaker/PacemakerServer.java

View workflow job for this annotation

GitHub Actions / test (25, Server, false)

org.apache.storm.pacemaker.codec.ThriftNettyServerCodec in org.apache.storm.pacemaker.codec has been deprecated and marked for removal
private final EventLoopGroup bossEventLoopGroup;
private final EventLoopGroup workerEventLoopGroup;

PacemakerServer(IServerMessageHandler handler, Map<String, Object> config) {

Check warning on line 65 in storm-server/src/main/java/org/apache/storm/pacemaker/PacemakerServer.java

View workflow job for this annotation

GitHub Actions / test (25, Server, false)

org.apache.storm.pacemaker.IServerMessageHandler in org.apache.storm.pacemaker has been deprecated and marked for removal
int port = (int) config.get(Config.PACEMAKER_PORT);
this.handler = handler;
this.topologyName = "pacemaker_server";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
* Use the default heartbeat path instead: workers heartbeat to their supervisor, which reports them to Nimbus over
* Thrift, with the default ZooKeeper-based cluster state store ({@code org.apache.storm.cluster.ZKStateStorageFactory}).
*/
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public class PacemakerServerHandler extends StormServerHandler {
private static final Logger LOG = LoggerFactory.getLogger(PacemakerServerHandler.class);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
* Use the default heartbeat path instead: workers heartbeat to their supervisor, which reports them to Nimbus over
* Thrift, with the default ZooKeeper-based cluster state store ({@code org.apache.storm.cluster.ZKStateStorageFactory}).
*/
@Deprecated(since = "3.1.0", forRemoval = true)
@Deprecated(since = "3.2.0", forRemoval = true)
public class ThriftNettyServerCodec extends ChannelInitializer<Channel> {

public static final String SASL_HANDLER = "sasl-handler";
Expand Down
Loading