[SYSTEMDS-3857] set get names on frame#2558
Draft
t99-i wants to merge 9 commits into
Draft
Conversation
This patch adds the language references for the newly implemented getName and setName function. The order in Builtins.java was fixed to be alphabetical again
- fixed mapping of binarOP in DMLTranslator - added size/data validation in BinaryFrameFrameCPInstruction - setName does now have a STRING return type - removed duplicated code - fixed get/set-swap - removed unnecessary prints in FrameColumnNamesTest - removed unnecessary TODOs
- added SetName functionality for SPARK - extended propagation test (wip) - added Set/GetNames function tests for SPARK
- removed propagation test from this branch
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2558 +/- ##
============================================
+ Coverage 71.47% 71.63% +0.16%
- Complexity 48883 50162 +1279
============================================
Files 1573 1614 +41
Lines 189238 194052 +4814
Branches 37128 37944 +816
============================================
+ Hits 135261 139017 +3756
- Misses 43530 44122 +592
- Partials 10447 10913 +466 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the frame operations getNames and setNames.
Changes:
Added getNames support in compiler, CP and Spark runtime
Added setNames support in compiler, CP and Spark runtime
Added tests for getNames and setNames
Updated DML language reference