Skip to content

chore(amber): remove the unused SchemaPropagationResponse - #7453

Open
aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:chore/remove-schema-propagation-response
Open

chore(amber): remove the unused SchemaPropagationResponse#7453
aglinxinyuan wants to merge 1 commit into
apache:mainfrom
aglinxinyuan:chore/remove-schema-propagation-response

Conversation

@aglinxinyuan

@aglinxinyuan aglinxinyuan commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Deletes SchemaPropagationResponse, an orphaned HTTP response model. Pure deletion, no behaviour change: −28 lines.

A repo-wide search for the name returns exactly one hit: the declaration itself. No @Path method returns it, there is no Jackson subtype registration for it, and no frontend interface mirrors it. What remains of the file is a single five-line case class plus the licence header.

Reviewer note: the similarly-named SchemaPropagationFunc in common/workflow-core is unrelated, live, and untouched — only the web/model/http/response case class is removed.

Any related issues, documentation, discussions?

Closes #7450

How was this PR tested?

Existing tests only — this PR adds none; nothing referenced the removed class, so no spec covered it.

Locally, from the repo root with Java 17:

  • sbt "WorkflowExecutionService/Test/compile" — success.

Verification, re-runnable by a reviewer:

git grep -n SchemaPropagationResponse    # only the deleted file

Was this PR authored or co-authored using generative AI tooling?

Generated-by: Claude Code (Claude Opus 5)

Copilot AI lite review requested due to automatic review settings August 9, 2026 11:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Automated Reviewer Suggestions

Based on the git blame history of the changed files, we recommend the following reviewers:

  • No candidates found from git blame history.

@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

⚠️ Benchmark changes need a look

🟢 0 better · 🔴 1 worse · ⚪ 14 noise (<±5%) · 0 without baseline

Compared against main e03d971 benchmarked on this same runner, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.

Dashboard · Run

config throughput MB/s latency max Δ latest / 7d
bs=10 sw=10 sl=64 438 0.267 21,804/31,206/31,206 us ⚪ within ±5% / 🔴 +93.6%
🔴 bs=100 sw=10 sl=64 914 0.558 107,746/141,042/141,042 us 🔴 +5.1% / 🔴 +26.8%
bs=1000 sw=10 sl=64 1,079 0.659 922,105/982,415/982,415 us ⚪ within ±5% / 🟢 -10.3%
Baseline details

Latest main e03d971 from same runner

config metric PR latest main 7d avg Δ latest Δ 7d
bs=10 sw=10 sl=64 throughput 438 tuples/sec 428 tuples/sec 752.25 tuples/sec +2.3% -41.8%
bs=10 sw=10 sl=64 MB/s 0.267 MB/s 0.262 MB/s 0.459 MB/s +1.9% -41.8%
bs=10 sw=10 sl=64 p50 21,804 us 22,617 us 13,006 us -3.6% +67.6%
bs=10 sw=10 sl=64 p95 31,206 us 32,245 us 16,117 us -3.2% +93.6%
bs=10 sw=10 sl=64 p99 31,206 us 32,245 us 19,286 us -3.2% +61.8%
bs=100 sw=10 sl=64 throughput 914 tuples/sec 947 tuples/sec 953.66 tuples/sec -3.5% -4.2%
bs=100 sw=10 sl=64 MB/s 0.558 MB/s 0.578 MB/s 0.582 MB/s -3.5% -4.1%
bs=100 sw=10 sl=64 p50 107,746 us 102,477 us 105,130 us +5.1% +2.5%
bs=100 sw=10 sl=64 p95 141,042 us 142,849 us 111,226 us -1.3% +26.8%
bs=100 sw=10 sl=64 p99 141,042 us 142,849 us 121,065 us -1.3% +16.5%
bs=1000 sw=10 sl=64 throughput 1,079 tuples/sec 1,086 tuples/sec 984.25 tuples/sec -0.6% +9.6%
bs=1000 sw=10 sl=64 MB/s 0.659 MB/s 0.663 MB/s 0.601 MB/s -0.6% +9.7%
bs=1000 sw=10 sl=64 p50 922,105 us 919,077 us 1,024,295 us +0.3% -10.0%
bs=1000 sw=10 sl=64 p95 982,415 us 1,023,054 us 1,062,710 us -4.0% -7.6%
bs=1000 sw=10 sl=64 p99 982,415 us 1,023,054 us 1,095,400 us -4.0% -10.3%
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,456.88,200,128000,438,0.267,21804.16,31205.68,31205.68
1,100,10,64,20,2189.07,2000,1280000,914,0.558,107746.01,141042.14,141042.14
2,1000,10,64,20,18527.46,20000,12800000,1079,0.659,922105.33,982415.47,982415.47

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.34%. Comparing base (e03d971) to head (d67ce9f).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #7453      +/-   ##
============================================
+ Coverage     85.32%   85.34%   +0.01%     
- Complexity     4151     4153       +2     
============================================
  Files          1169     1168       -1     
  Lines         46740    46736       -4     
  Branches       5202     5202              
============================================
+ Hits          39882    39885       +3     
+ Misses         5148     5143       -5     
+ Partials       1710     1708       -2     
Flag Coverage Δ *Carryforward flag
access-control-service 70.00% <ø> (ø) Carriedforward from e03d971
agent-service 85.50% <ø> (ø) Carriedforward from e03d971
amber 80.92% <ø> (+0.03%) ⬆️
computing-unit-managing-service 50.72% <ø> (ø) Carriedforward from e03d971
config-service 65.97% <ø> (ø) Carriedforward from e03d971
file-service 69.05% <ø> (ø) Carriedforward from e03d971
frontend 87.85% <ø> (ø) Carriedforward from e03d971
notebook-migration-service 78.89% <ø> (ø) Carriedforward from e03d971
pyamber 97.51% <ø> (ø) Carriedforward from e03d971
workflow-compiling-service 26.31% <ø> (ø) Carriedforward from e03d971

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the orphaned SchemaPropagationResponse HTTP model

3 participants