chore(amber): remove the unused SchemaPropagationResponse - #7453
Open
aglinxinyuan wants to merge 1 commit into
Open
chore(amber): remove the unused SchemaPropagationResponse#7453aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| ⚪ | bs=10 sw=10 sl=64 | 438 | 0.267 | 21,804/31,206/31,206 us | ⚪ within ±5% / 🔴 +93.6% |
| 🔴 | bs=100 sw=10 sl=64 | 914 | 0.558 | 107,746/141,042/141,042 us | 🔴 +5.1% / 🔴 +26.8% |
| ⚪ | bs=1000 sw=10 sl=64 | 1,079 | 0.659 | 922,105/982,415/982,415 us | ⚪ within ±5% / 🟢 -10.3% |
Baseline details
Latest main e03d971 from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 438 tuples/sec | 428 tuples/sec | 752.25 tuples/sec | +2.3% | -41.8% |
| bs=10 sw=10 sl=64 | MB/s | 0.267 MB/s | 0.262 MB/s | 0.459 MB/s | +1.9% | -41.8% |
| bs=10 sw=10 sl=64 | p50 | 21,804 us | 22,617 us | 13,006 us | -3.6% | +67.6% |
| bs=10 sw=10 sl=64 | p95 | 31,206 us | 32,245 us | 16,117 us | -3.2% | +93.6% |
| bs=10 sw=10 sl=64 | p99 | 31,206 us | 32,245 us | 19,286 us | -3.2% | +61.8% |
| bs=100 sw=10 sl=64 | throughput | 914 tuples/sec | 947 tuples/sec | 953.66 tuples/sec | -3.5% | -4.2% |
| bs=100 sw=10 sl=64 | MB/s | 0.558 MB/s | 0.578 MB/s | 0.582 MB/s | -3.5% | -4.1% |
| bs=100 sw=10 sl=64 | p50 | 107,746 us | 102,477 us | 105,130 us | +5.1% | +2.5% |
| bs=100 sw=10 sl=64 | p95 | 141,042 us | 142,849 us | 111,226 us | -1.3% | +26.8% |
| bs=100 sw=10 sl=64 | p99 | 141,042 us | 142,849 us | 121,065 us | -1.3% | +16.5% |
| bs=1000 sw=10 sl=64 | throughput | 1,079 tuples/sec | 1,086 tuples/sec | 984.25 tuples/sec | -0.6% | +9.6% |
| bs=1000 sw=10 sl=64 | MB/s | 0.659 MB/s | 0.663 MB/s | 0.601 MB/s | -0.6% | +9.7% |
| bs=1000 sw=10 sl=64 | p50 | 922,105 us | 919,077 us | 1,024,295 us | +0.3% | -10.0% |
| bs=1000 sw=10 sl=64 | p95 | 982,415 us | 1,023,054 us | 1,062,710 us | -4.0% | -7.6% |
| bs=1000 sw=10 sl=64 | p99 | 982,415 us | 1,023,054 us | 1,095,400 us | -4.0% | -10.3% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,456.88,200,128000,438,0.267,21804.16,31205.68,31205.68
1,100,10,64,20,2189.07,2000,1280000,914,0.558,107746.01,141042.14,141042.14
2,1000,10,64,20,18527.46,20000,12800000,1079,0.659,922105.33,982415.47,982415.47
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7453 +/- ##
============================================
+ Coverage 85.32% 85.34% +0.01%
- Complexity 4151 4153 +2
============================================
Files 1169 1168 -1
Lines 46740 46736 -4
Branches 5202 5202
============================================
+ Hits 39882 39885 +3
+ Misses 5148 5143 -5
+ Partials 1710 1708 -2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Deletes
SchemaPropagationResponse, an orphaned HTTP response model. Pure deletion, no behaviour change: −28 lines.A repo-wide search for the name returns exactly one hit: the declaration itself. No
@Pathmethod returns it, there is no Jackson subtype registration for it, and no frontend interface mirrors it. What remains of the file is a single five-line case class plus the licence header.Any related issues, documentation, discussions?
Closes #7450
How was this PR tested?
Existing tests only — this PR adds none; nothing referenced the removed class, so no spec covered it.
Locally, from the repo root with Java 17:
sbt "WorkflowExecutionService/Test/compile"— success.Verification, re-runnable by a reviewer:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)