chore(frontend): remove the deprecated project feature - #7463
Open
aglinxinyuan wants to merge 1 commit into
Open
chore(frontend): remove the deprecated project feature#7463aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7463 +/- ##
============================================
- Coverage 85.32% 85.31% -0.02%
Complexity 4151 4151
============================================
Files 1169 1156 -13
Lines 46740 46108 -632
Branches 5202 5146 -56
============================================
- Hits 39882 39337 -545
+ Misses 5148 5068 -80
+ Partials 1710 1703 -7
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Yicong-Huang
self-requested a review
August 9, 2026 16:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Removes the deprecated project feature from the Angular frontend. The feature was hidden behind
projects_enabled = falsein #3343 (2025-04-02) and has been unmaintained since; #5172 reached consensus to delete it rather than keep carrying it.This is the frontend half. The backend endpoints and the database schema go separately, so this PR is safe to land on its own — the
/projectendpoints simply stop being called.27 files deleted, 55 edited (+79 / −4798).
user-project/tree — list page, section page, list item, public-project modal, add/remove-workflow modals (22 files)UserProjectService,StubUserProjectService,PublicProjectServiceDashboardProject/PublicProject,SearchResult.project,isDashboardProject,DashboardWorkflow.projectIDsuser/project,user/project/:pid, theUSER_PROJECTconstant, 6app.module.tsdeclarationsSidebarTabs.projects_enabled, the sidebar tab, the admin-settings toggleprojectIdssearch params, the project arm of the entry builder,EntityType.ProjectUI impact. Every surface below
projects_enabledwas already hidden by default, so a default deployment renders identically before and after — no user-visible change to screenshot. The one exception is the admin settings page, which loses its now-meaningless Projects toggle row (twelve switches → eleven).Two adjacent cleanups were deliberately left out of scope, since they are unrelated dead code rather than part of this feature:
hub-search-result.component.ts's@Input() accessLevelandsearch-results.component.ts's@Input() pid.Any related issues, documentation, discussions?
Closes #7460
Removal agreed in #5172; the backend and schema half is #7461. Also updates
frontend/README.md, the only doc line that named the feature.How was this PR tested?
Existing tests, adjusted where a project fixture was doing double duty as a generic sample (e.g. the "non-shareable entry" case now uses
"file"instead of"project"), and deleted where a test existed solely to exercise project behaviour.tsc --noEmitng test --watch=falseeslint ./srcprettier-eslint --list-differentng buildwas also run: it reports 13 errors, all insidenode_modules(monaco.ttf/.svg/.cssloaders) and none undersrc/app. Confirmed pre-existing rather than caused by this change by building a pristineorigin/mainworktree against the samenode_modules— identical 13 errors.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)