chore(amber): remove the deprecated project feature and its tables - #7464
Open
aglinxinyuan wants to merge 1 commit into
Open
chore(amber): remove the deprecated project feature and its tables#7464aglinxinyuan wants to merge 1 commit into
aglinxinyuan wants to merge 1 commit into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7464 +/- ##
============================================
- Coverage 85.32% 85.30% -0.03%
+ Complexity 4151 4112 -39
============================================
Files 1169 1165 -4
Lines 46740 46512 -228
Branches 5202 5188 -14
============================================
- Hits 39882 39675 -207
+ Misses 5148 5135 -13
+ Partials 1710 1702 -8
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
| config | throughput | MB/s | latency | max Δ latest / 7d | |
|---|---|---|---|---|---|
| 🔴 | bs=10 sw=10 sl=64 | 424 | 0.259 | 23,394/28,363/28,363 us | 🔴 +90.9% / 🔴 +78.2% |
| 🔴 | bs=100 sw=10 sl=64 | 821 | 0.501 | 120,649/150,448/150,448 us | 🔴 +50.4% / 🔴 +33.7% |
| 🔴 | bs=1000 sw=10 sl=64 | 950 | 0.58 | 1,055,127/1,087,449/1,087,449 us | 🔴 +14.7% / ⚪ within ±5% |
Baseline details
Latest main e03d971 from 2026-08-09T12:55:54.590Z
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---|---|---|---|---|
| bs=10 sw=10 sl=64 | throughput | 424 tuples/sec | 800.61 tuples/sec | 743.73 tuples/sec | -47.0% | -43.0% |
| bs=10 sw=10 sl=64 | MB/s | 0.259 MB/s | 0.489 MB/s | 0.454 MB/s | -47.0% | -42.9% |
| bs=10 sw=10 sl=64 | p50 | 23,394 us | 12,254 us | 13,130 us | +90.9% | +78.2% |
| bs=10 sw=10 sl=64 | p95 | 28,363 us | 15,377 us | 16,391 us | +84.5% | +73.0% |
| bs=10 sw=10 sl=64 | p99 | 28,363 us | 17,693 us | 19,408 us | +60.3% | +46.1% |
| bs=100 sw=10 sl=64 | throughput | 821 tuples/sec | 1,069 tuples/sec | 944.04 tuples/sec | -23.2% | -13.0% |
| bs=100 sw=10 sl=64 | MB/s | 0.501 MB/s | 0.652 MB/s | 0.576 MB/s | -23.2% | -13.1% |
| bs=100 sw=10 sl=64 | p50 | 120,649 us | 92,789 us | 105,853 us | +30.0% | +14.0% |
| bs=100 sw=10 sl=64 | p95 | 150,448 us | 100,036 us | 112,493 us | +50.4% | +33.7% |
| bs=100 sw=10 sl=64 | p99 | 150,448 us | 106,858 us | 122,200 us | +40.8% | +23.1% |
| bs=1000 sw=10 sl=64 | throughput | 950 tuples/sec | 1,087 tuples/sec | 972.22 tuples/sec | -12.6% | -2.3% |
| bs=1000 sw=10 sl=64 | MB/s | 0.58 MB/s | 0.663 MB/s | 0.593 MB/s | -12.6% | -2.3% |
| bs=1000 sw=10 sl=64 | p50 | 1,055,127 us | 919,503 us | 1,033,856 us | +14.7% | +2.1% |
| bs=1000 sw=10 sl=64 | p95 | 1,087,449 us | 970,060 us | 1,076,083 us | +12.1% | +1.1% |
| bs=1000 sw=10 sl=64 | p99 | 1,087,449 us | 1,014,468 us | 1,107,701 us | +7.2% | -1.8% |
Raw CSV
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,471.55,200,128000,424,0.259,23393.80,28363.47,28363.47
1,100,10,64,20,2435.12,2000,1280000,821,0.501,120649.21,150448.21,150448.21
2,1000,10,64,20,21060.56,20000,12800000,950,0.580,1055127.36,1087448.54,1087448.54
Yicong-Huang
self-requested a review
August 9, 2026 16:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Removes the deprecated project feature from the backend and drops its four tables, completing the removal agreed in #5172.
8 files deleted, 18 edited (+66 / −1955).
ProjectResource,PublicProjectResource,ProjectAccessResource+ their threejersey.registerlines inTexeraWebApplicationProjectSearchQueryBuilder,PROJECT_RESOURCE_TYPE, both project arms ofDashboardResource, and 4 of the 24UnifiedResourceSchemaslotsDashboardWorkflow.projectIDs,WorkflowIDs.pid,Record10→Record9gui.tabs.projects_enabled/GUI_TABS_PROJECTS_ENABLEDsql/updates/32.sqland its changelog entryprivilege_enumstays — it is shared withworkflow_user_access,dataset_user_accessandcomputing_unit_user_access.Two behaviour changes reviewers should look at. Both are non-project code paths that read the project tables today:
WorkflowAccessResource.getPrivilegePROJECT_USER_ACCESSwhen there is no direct grantWORKFLOW_USER_ACCESSgrant countsWorkflowSearchQueryBuilderprivate-access conditionWORKFLOW_USER_ACCESS.UID = uid OR PROJECT_USER_ACCESS.UID IS NOT NULLWORKFLOW_USER_ACCESS.UID = uidA workflow reachable only through a project share becomes inaccessible to that user. That is the intended consequence of dropping the feature —
notebook-migration-servicealready documents exactly these post-removal semantics — but it is called out in32.sqlso operators can copy those grants intoworkflow_user_accessbefore migrating.jOOQ. Generated sources are not committed (
common/dao/.gitignore);sbt jooqGeneratereflects the live database. So the DDL change and the Scala change have to land together, and the migration must be applied before regenerating — otherwise the old classes reappear and stale references still compile.sql/updates/02.sqlis left untouched: it is already applied, and editing it would break its liquibase checksum.bin/k8s/files/texera_ddl.sqlis a symlink tosql/texera_ddl.sql, so the helm chart is covered automatically.Any related issues, documentation, discussions?
Closes #7461
Removal agreed in #5172; the frontend half is #7460. The two are independent and can merge in either order.
How was this PR tested?
Existing tests. The
/search APIsuite inWorkflowResourceSpecseeded projects and asserted counts that included them, so those eight tests were rewritten workflow-only with adjusted counts;UnifiedResourceSchemaSpec's pinned projection arity went 24 → 20.scalafmtCheckAll+scalafixAll --checkThe spec run is the meaningful check on the schema change:
MockTexeraDBbootstraps embedded Postgres from the editedtexera_ddl.sql, so those 197 tests all ran against a database with no project tables. Any surviving query against a dropped table would have failed there.MockTexeraDB's hard-coded fulltext-index block was updated in lockstep — it referencedON projectand would otherwise take out every DAO-backed suite in the repo.Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Opus 5)