fix(visualization, v1.2): take the union of Network Graph's two node columns - #7518
Open
kz930 wants to merge 1 commit into
Open
fix(visualization, v1.2): take the union of Network Graph's two node columns#7518kz930 wants to merge 1 commit into
kz930 wants to merge 1 commit into
Conversation
…columns Network Graph built its node set with `set(sources + destinations)`. On two pandas Series `+` is element-wise, so the set held each source glued to its destination rather than the union of the two columns; those glued values were added to the graph as nodes, and the genuine nodes only arrived afterwards with the edges. This takes the union instead, in first-appearance order -- a `set` iterates strings in an order that varies between processes, which would leave the node sequence unstable from run to run. NetworkGraphOpDescSpec does not exist on this branch, so it arrives with the one case asserting the node set is built as a union. Its other cases on main belong to the not-blank validation messages, which this branch does not carry. (backported from commit 357296d) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Automated Reviewer SuggestionsBased on the
|
xuang7
approved these changes
Aug 10, 2026
xuang7
enabled auto-merge
August 10, 2026 20:17
Contributor
Author
|
@xuang7 I think this is good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Backport of #7327 to
release/v1.2, superseding #7401. That PR's branch lives onapache/texerarather than a fork, so the conflict resolution could not be pushed to it.The operator change is #7327's, unchanged. Network Graph built its node set with
set(sources + destinations); on two pandas Series+is element-wise, so the set held each source glued to its destination rather than the union of the two columns. This takes the union in first-appearance order.The cherry-pick's one conflict was
NetworkGraphOpDescSpec.scala, which does not exist onrelease/v1.2— it was created on main by #5640, which was never backported. Resolving that modify/delete by taking the whole file, which is what #7401 carries, brings across three cases asserting the assertion text names the empty field. This branch still has a bareassert(source.nonEmpty), so those three fail here: running #7401's branch as it stands gives three passed and three failed. This backport instead carries only the case #7327 added, so what lands is the one-line operator fix and the test that pins it.Any related issues, documentation, discussions?
Backport of #7327. Originally linked #7325. Supersedes #7401, which can be closed.
How was this PR tested?
NetworkGraphOpDescSpecon this branch: one case, passing. Reverting the operator line leaves it failing.WorkflowOperator/scalafmtCheckAllandWorkflowOperator/scalafixAll --checkare both clean.The operator change is byte-identical to #7327, where it was verified by dumping and executing the generated module over rows carrying known edges.
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 5)