Repository navigation
TOMEE-4733 - Use surefire.version in MicroProfile TCK modules - #3156
Merged
Merged
Conversation
The MicroProfile TCK poms hard-code the Surefire version, so the 3.5.6 pin in tck/pom.xml does not apply to them. Config and JWT TCK still run Surefire 3.6.1 and fail on suiteXmlFiles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3154. The MicroProfile TCK poms hard-code
<version>3.6.1</version>for Surefire, so the 3.5.6 pin intck/pom.xmldoesn't apply to them. Config and JWT TCK still run Surefire 3.6.1 and fail withParameter "suiteXmlFiles" is not supported since 3.6.0.Failing build: https://ci-builds.apache.org/job/Tomee/view/tomee-11.x/job/master-build-full/2341/
This switches the hard-coded versions to
${surefire.version}. Checked locally that all MicroProfile TCK modules resolve to 3.5.6 and that Config/JWT get throughsurefire:test(no TCK tests run).Jira: https://issues.apache.org/jira/browse/TOMEE-4733
🤖 Generated with Claude Code