Handle all cachekey regex capture groups - #13653
Open
bneradt wants to merge 1 commit into
Open
Conversation
Cachekey patterns with ten or more capture groups can crash ATS when building a cache key because a successful match leaves the capture vector empty. Replacement patterns also reject valid group references when the default match buffer is too small. This patch sizes match buffers for the complete pattern, uses the available match count, and rejects empty capture results before iteration. Replay coverage verifies complete cache keys across the capture limit and preserves replacement and no-match behavior. Fixes: apache#13638 Co-authored-by: GPT-6 Astra Light
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cachekey patterns with ten or more capture groups can crash ATS when
building a cache key because a successful match leaves the capture
vector empty. Replacement patterns also reject valid group references
when the default match buffer is too small.
This patch sizes match buffers for the complete pattern, uses the
available match count, and rejects empty capture results before
iteration. Replay coverage verifies complete cache keys across the
capture limit and preserves replacement and no-match behavior.
Fixes: #13638
Co-authored-by: GPT-6 Astra Light