[TIR] Ignore None-valued pragma annotations - #20265
Open
StrongbodyStrongmind wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18393.
None-valued pragma annotations represent an unspecified pragma and should not be lowered into
AttrStmtnodes with undefinedPrimExprvalues.Previously,
pragma_unroll_explicit=Nonewas lowered into anAttrStmtwith an undefined value. DuringFlattenBuffer,StmtExprMutatorattempted to visit that value and triggered a segmentation fault.This patch skips
None-valued pragma annotations during opaque lowering while preserving the existing behavior for valid pragma values.For
pragma_unroll, the existing upstream behavior is preserved: non-null values remain attached to the loop, while null values are ignored.Tests:
tests/python/tirx-transform/test_tir_transform_flatten_buffer.py: 11 passedtests/python/s_tir/transform/test_s_tir_transform_lower_opaque_block.py: 13 passedgit diff --check upstream/main..HEAD: passed