Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An application-installed, unnamed
logging.StreamHandlerorlogging.NullHandlermakes MetaSchedule task logger initialization fail withAttributeError: 'NoneType' object has no attribute 'format'.create_loggersincludes the handler's defaultNonename in references that are later formatted as strings.Skip unnamed existing handlers when constructing those named references. Add a subprocess-isolated regression covering both handler types and a no-handler control; each case initializes twice and verifies messages in both task log files.
Fixes #20828.
Validation on macOS arm64, Python 3.12.11, with a clean CPU-only build of TVM main (
e345029c):AttributeError; the no-handler control passes.5 passed).pre-commit run --files python/tvm/s_tir/meta_schedule/logging.py tests/python/s_tir/meta_schedule/test_meta_schedule_logging.py: all applicable hooks pass.