Repository navigation
Bump org.openrewrite.recipe:rewrite-recipe-bom from 3.26.1 to 3.38.0 - #1557
dependabot[bot] wants to merge 2 commits into
Conversation
Bumps [org.openrewrite.recipe:rewrite-recipe-bom](https://github.com/openrewrite/rewrite-recipe-bom) from 3.26.1 to 3.38.0. - [Release notes](https://github.com/openrewrite/rewrite-recipe-bom/releases) - [Commits](openrewrite/rewrite-recipe-bom@v3.26.1...v3.38.0) --- updated-dependencies: - dependency-name: org.openrewrite.recipe:rewrite-recipe-bom dependency-version: 3.38.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
|
That's such a pain in the ass. Our current version is not compatible with Java 27. |
|
Let me try to fix it! |
|
@timtebeek Could you please help us here ? I can see it at https://artifacts.codegenomeproject.org/maven/org/openrewrite/recipe/rewrite-github-actions/3.30.0/ It looks like a file system access permissions issue to me. |
|
Thanks for the tag @martin-g and sorry to hear about your troubles. It's indeed an access permission issue. The CGP offers free downloads for any Apache licensed modules, but the three you've referenced fall under Moderne Source Available License: https://docs.moderne.io/user-documentation/recipes/accessing-the-code-genome-project/#what-the-repository-hosts Looking across which recipes are used & pulled in here they seem to come in through these two That brings us to a few different ways forward:
I understand neither is ideal from a user perspective, but it's what I can offer based on decisions beyond my control. |
|
Thanks for your quick response, @timtebeek ! Open-Rewrite is a cool idea but the decisions taken and the implementation is not good! I've added exclusions for the problematic modules and now the build fails with dependency convergence errors: This has always been a pain with openrewrite updates in Wicket. Lately a LLM agent does pretty good job in helping with migrations, so based on the problems above my opinion is that wicket-migration module should be removed for Wicket 11 and documented as deprecated for Wicket 10. |
Of course, trying to help as best I can.
No we very strictly only have dependencies pointing from proprietary & source available modules to the Apache licensed modules. None of that has changed; the modules you're depending on just aren't Apache licensed, but were on Maven Central all the same. You can see the full list of licensed on https://docs.openrewrite.org/reference/latest-versions-of-every-openrewrite-module
Hmm, that listing shows you still use
While I can't stop you there, I can say from our experience users will have the best results (in terms of performance, costs, and predicability) when doing as much as possible in a deterministic way, before handing off to LLMs. Something to consider, as these types of changes are mechanical: wicket/wicket-migration/src/main/resources/META-INF/rewrite/wicket.yml Lines 98 to 126 in 003cf99 If you still choose to drop the module I'd understand; thanks for working with us so far and all the best going forward. ❤️ |
Bumps org.openrewrite.recipe:rewrite-recipe-bom from 3.26.1 to 3.38.0.
Release notes
Sourced from org.openrewrite.recipe:rewrite-recipe-bom's releases.
... (truncated)
Commits
f4d6057Drop the Gradle Plugin Portal repository so org.openrewrite:plugin resolves f...f6c1445Pass the renamed CODEGENOME_USERNAME/TOKEN secrets to gh-automation (#65)616948fRun the scheduled build after the repos it aggregates (#64)86d9c01Drop rewrite-codemods from the BOM (#63)70b4355Resolve dependencies from the Code Genome Project (#62)b7f6177Exclude jgit from checkBomAlignment (#60)4af1deaManage org.openrewrite.tools:jgit-gpg-bc in the BOM (#59)6ee6c76Renew and reclassify OWASP suppressions; suppress jna and netty CVE-2026-5681...547c273Remove Maven Central badges from README files1836a5aPublish rewrite-recipe-bom to the Code Genome Project (#57)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)