[MINOR] Refresh search indexes after paragraph edits - #5463
Open
kkalyan wants to merge 1 commit into
Open
Conversation
Notify paragraph update listeners after successful service and REST edits so search implementations replace stale indexed text. Add service and REST coverage using Lucene search.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
As of now, search index (lucene and embedding) are not updated on paragraph edits.
This change fires
fireParagraphUpdateEventafter each successful save, allowing both Lucene and embedding search implementations to refresh the affected paragraph immediately.Paragraph edits made through
NotebookService.updateParagraphor the paragraph RESTPUTendpoint are saved but do not fire a paragraph update event. As a result,SearchServiceimplementations keep the old paragraph text until a full index rebuild or server restart.What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
No Jira issue has been created yet. This is currently submitted as a
[MINOR]bug fix.How should this be tested?
Automated tests:
The tests update paragraph text through both supported paths and verify that the new text is returned by Lucene search.
Screenshots (if appropriate)
N/A
Questions: