Repository navigation
Conversation
There was a problem hiding this comment.
Thanks, moving the button out of the overlay fixes the overlap at its root.
One regression (this works on master): on page 2, a column filter that matches nothing leaves the previous page's rows visible above "No Data", and "Export visible data" exports them. Rerunning with fewer rows hits the same path.
| Before | After (clamp below) |
|---|---|
![]() |
![]() |
nz-table ignores an out-of-range pageIndex instead of clamping it. The built-in pagination used to reset it, but the footer pagination is now removed by @if (rows.length > 0) exactly when rows become empty. Clamping at the end of filterRows() covers render, search, sort and type change:
this.pageIndex = Math.min(this.pageIndex, Math.max(1, Math.ceil(this.rows.length / this.pageSize)));Minor: the button's accessible name is "Export down" (from the icon), and exact is ignored for a RegExp name. aria-label="Export" lets the locator be { name: 'Export', exact: true }.
Both, with a unit spec, are in this commit for reference: voidmatcha@d4c5940a18


What is this PR for?
Fixes the table result’s bottom Export button being unresponsive to hover and click.
The button was absolutely positioned over the table’s pagination area. Although the pagination controls appeared on the right, their container spanned the full table width and intercepted pointer events intended for Export.
This PR places Export and pagination in a shared, wrapping footer. They retain the existing left/right arrangement when space permits and wrap onto separate lines in narrow paragraphs, without overlapping.
The table’s built-in pagination UI is replaced with an external nz-pagination control sharing the table’s page index and page size. nz-table still handles row pagination, and the existing sorting, filtering, aggregation, and export logic remains unchanged.
What type of PR is it?
Bug Fix
What is the Jira issue?
How should this be tested?
With a Zeppelin development server and the Shell interpreter available, run the existing Chromium E2E script from zeppelin-web-angular:
The new tests verify that:
The existing visualization tests check table rendering and data preservation after switching between chart modes.
For manual verification:
Questions: