Repository navigation
[ZEPPELIN-6593] Preserve false interpreter property values - #5592
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
voidmatcha
approved these changes
Oct 27, 2026
voidmatcha
left a comment
voidmatcha
left a comment
Member
There was a problem hiding this comment.
Thanks! Verified on a local build: checkbox properties sent as false (e.g. zeppelin.shell.interpolation) were blank in view mode, indistinguishable from unset values. They now show false, and empty values stay blank. This also matches the Classic UI, which renders the value as-is ({{property.value}}) in view mode.
| Before (master) | After (this PR) |
|---|---|
 |
 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ZEPPELIN-6593.
The New UI's view-mode property cell used a truthy fallback, so a boolean
falsevalue rendered as blank. Route the cell through a nullish formatter instead, preservingfalseandtruewhile keeping nullish values empty. Password masking and checkbox editing remain unchanged.Verification:
npm run test:shell -- src/app/pages/workspace/interpreter/item/item.component.spec.ts— 4 tests passed. Vite emitted a missing Monaco source-map warning.npm run lintdid not complete: the separate React remote lint could not resolve its uninstalledeslint-plugin-reactdependency. No React files are changed.