ci: restore the PMU_VERSION pin that the merge up dropped - #8474
ci: restore the PMU_VERSION pin that the merge up dropped#8474ousamabenyounes wants to merge 1 commit into
Conversation
The pin landed on 4.3 in api-platform#8442, but merging up to main kept the 21 "soyuka/pmu:$PMU_VERSION" call sites while dropping the env entry that defines the variable. Every job that installs pmu therefore runs composer global require "soyuka/pmu:" and aborts with "Option soyuka/pmu is missing a version constraint", which is why main is currently red in 90 of its 91 failing checks and every pull request targeting it fails the same way. Restore the env entry, and constrain the one remaining call site in the Upgrade Filter Codemod job that api-platform#8442 did not cover, so no job installs whatever version the registry serves that day.
|
CI on this PR is red, and that is the point of it — worth spelling out so the list is not misread as fallout from a four-line workflow change. Before this PR, 90 of 1. Fixed by #8445 — the constraint under-declaration these jobs were always going to hit:
2. Pre-existing on
3. Nothing in group 2 or 3 can be caused by defining an env variable; they were simply unreachable while every job aborted at install. Happy to split any of them into its own PR if you'd like them tracked separately. |
mainis currently red in 90 of its 91 failing checks, and so is every pullrequest targeting it — #8448
shows 108 failures, all from the same step.
Cause
#8442 pinned the build tooling by introducing
PMU_VERSIONin the workflowenv:block and rewriting every call site to
soyuka/pmu:$PMU_VERSION. That landed on4.3. Merging up tomainkept the 21 rewritten call sites but dropped theenv:entry that defines the variable, so the command expands to:and composer aborts:
Every job that installs pmu dies there — the step is variously named
Update project dependencies,PMUorLinking, which is why the failure lookslike several unrelated problems. It is one.
Change
PMU_VERSIONentry inenv:, with the same value and comment as4.3.Upgrade Filter Codemodjob still ran the unpinned
composer global require soyuka/pmu, which is exactlywhat that comment warns against.
Validation
This is a workflow-config change, so there is no meaningful unit test to add. The
invariant it restores is checkable directly — every
composer global require soyuka/pmumust carry a constraint, and that constraint must resolve:PMU_VERSIONdefined$PMU_VERSIONmainbeforemainafter4.3(reference)CI on this PR exercises the fix directly: the jobs that abort on
mainare thesame ones that must reach their real work here.