Repository navigation
Conversation
api-platform#7829 made SkolemIriConverter implement ResetInterface, but the service definition is not tagged, so Symfony's services_resetter never calls reset() and the object map keeps growing in long-running workers. Tag the service and assert the tag in the extension test. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7829 made
SkolemIriConverterimplementResetInterface, but theapi_platform.symfony.iri_converter.skolemservice is not taggedkernel.reset, so Symfony'sservices_resetternever callsreset(). In a long-running worker (FrankenPHP) the converter'sobjectHashMapkeeps every serialized DTO of every previous request: about 0.5 MB per request for a 200-DTO response, measured on 4.4.4, unchanged by #7829. The Laravel variant already callsreset()(aRequestHandledlistener inApiPlatformProvider, #7838).This adds the tag. The test is in
ApiPlatformExtensionTest::testSkolemIriConverterIsResetBetweenRequests: it fails without the tag (Tag "kernel.reset" not found on the service "api_platform.symfony.iri_converter.skolem") and passes with it. The same service definition is on 4.4 and main.