Skip to content

Only accept lowercase compact durations - #96

Merged
itssimon merged 1 commit into
mainfrom
fix-compact-duration-case
Oct 30, 2026
Merged

itssimon merged 1 commit into
mainfrom
fix-compact-duration-case

Conversation

@itssimon

Copy link
Copy Markdown
Member

resolve_relative_datetime lowercased the entire input, so a compact duration like 3M (which many users read as 3 months) was silently resolved as 3 minutes.

Compact durations (30m, 24h, 7d, 2w) are now matched case-sensitively and only accepted in lowercase. Uppercase forms like 3M, 24H or 7D are passed through unchanged, so the API rejects them instead of querying the wrong time range. ISO 8601 durations (P1M, PT30M, p14d) remain case-insensitive.

Also adds cmake to .tool-versions, so make install sets up everything needed to build DuckDB from source.

@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.99%. Comparing base (7dbdd63) to head (f045209).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   91.99%   91.99%           
=======================================
  Files          13       13           
  Lines        2485     2487    +2     
=======================================
+ Hits         2286     2288    +2     
  Misses        199      199           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@itssimon
itssimon merged commit acc4ed9 into main Oct 30, 2026
7 checks passed
@itssimon
itssimon deleted the fix-compact-duration-case branch October 30, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant