Update Indonesian translation#1554
Open
mcikadu-dev wants to merge 1 commit into
Open
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
📝 Walkthrough
WalkthroughThis change expands Indonesian Android localization with updated help copy and new UI, accessibility, diagnostics, permission, AI model, template, and profiler strings. ChangesLocalized Android resources
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@resources/src/main/res/values-in-rID/strings.xml`:
- Around line 13-19: Replace the space-based indentation with tabs for all
affected XML entries in resources/src/main/res/values-in-rID/strings.xml at
lines 13-19, 148-150, 338-346, 555-558, 627, 651, 665-667, 842, 1009-1012,
1022-1026, 1050-1064, 1190-1191, and 1224-1278, preserving the existing string
content and XML structure.
- Line 842: Rename sponsor_button_description to cd_sponsor_button_description
in the default strings, all layout/Compose references, and
resources/src/main/res/values-in-rID/strings.xml:842-842. Rename undock and
every floating_window_action_* key to the corresponding cd_* names in the
default strings, all usages, and
resources/src/main/res/values-in-rID/strings.xml:1224-1278, preserving the
translated values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7bc52144-cfea-4fad-a79d-ff651a7394c8
📒 Files selected for processing (1)
resources/src/main/res/values-in-rID/strings.xml
Comment on lines
+13
to
+19
| <string name="msg_need_help">Jika Anda mengalami masalah saat menggunakan Code on the Go atau dalam mengembangkan aplikasi Android, Anda dapat bergabung dengan forum Diskusi kami dan meminta bantuan di sana.\n\nAnda juga dapat mengirimkan saran melalui email kami.</string> | ||
| <string name="download_codeonthego_message">Unduh Code on the Go dari situs web resmi untuk mendapatkan fitur dan pembaruan terbaru.</string> | ||
| <string name="msg_invalid_url">URL tidak valid.</string> | ||
| <string name="msg_no_browser_found">Tidak ditemukan browser untuk menangani permintaan ini.</string> | ||
| <string name="need_help">Butuh Bantuan?</string> | ||
| <string name="ide_preferences">Preferensi IDE</string> | ||
| <string name="discussions_on_telegram">Diskusi di Telegram</string> | ||
| <string name="discussions_on_telegram">Forum dukungan dan diskusi</string> |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use tabs for XML indentation.
As per coding guidelines, XML files must use tabs for indentation. The newly added lines in this file consistently use spaces instead of tabs.
resources/src/main/res/values-in-rID/strings.xml#L13-L19: Convert 4-space indentation to tabs.resources/src/main/res/values-in-rID/strings.xml#L148-L150: Convert 4-space indentation to tabs.resources/src/main/res/values-in-rID/strings.xml#L338-L346: Convert 4-space indentation to tabs.resources/src/main/res/values-in-rID/strings.xml#L555-L558: Convert 4-space indentation to tabs.resources/src/main/res/values-in-rID/strings.xml#L627-L627: Convert 4-space indentation to tabs.resources/src/main/res/values-in-rID/strings.xml#L651-L651: Convert 4-space indentation to tabs.resources/src/main/res/values-in-rID/strings.xml#L665-L667: Convert 4-space indentation to tabs.resources/src/main/res/values-in-rID/strings.xml#L842-L842: Convert 4-space indentation to tabs.resources/src/main/res/values-in-rID/strings.xml#L1009-L1012: Convert 4-space indentation to tabs.resources/src/main/res/values-in-rID/strings.xml#L1022-L1026: Convert space indentation to tabs.resources/src/main/res/values-in-rID/strings.xml#L1050-L1064: Convert 4-space indentation to tabs.resources/src/main/res/values-in-rID/strings.xml#L1190-L1191: Convert 4-space indentation to tabs.resources/src/main/res/values-in-rID/strings.xml#L1224-L1278: Convert 4-space indentation to tabs.
📍 Affects 1 file
resources/src/main/res/values-in-rID/strings.xml#L13-L19(this comment)resources/src/main/res/values-in-rID/strings.xml#L148-L150resources/src/main/res/values-in-rID/strings.xml#L338-L346resources/src/main/res/values-in-rID/strings.xml#L555-L558resources/src/main/res/values-in-rID/strings.xml#L627-L627resources/src/main/res/values-in-rID/strings.xml#L651-L651resources/src/main/res/values-in-rID/strings.xml#L665-L667resources/src/main/res/values-in-rID/strings.xml#L842-L842resources/src/main/res/values-in-rID/strings.xml#L1009-L1012resources/src/main/res/values-in-rID/strings.xml#L1022-L1026resources/src/main/res/values-in-rID/strings.xml#L1050-L1064resources/src/main/res/values-in-rID/strings.xml#L1190-L1191resources/src/main/res/values-in-rID/strings.xml#L1224-L1278
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@resources/src/main/res/values-in-rID/strings.xml` around lines 13 - 19,
Replace the space-based indentation with tabs for all affected XML entries in
resources/src/main/res/values-in-rID/strings.xml at lines 13-19, 148-150,
338-346, 555-558, 627, 651, 665-667, 842, 1009-1012, 1022-1026, 1050-1064,
1190-1191, and 1224-1278, preserving the existing string content and XML
structure.
Source: Coding guidelines
|
|
||
| <string name="info_icon_content_description">Ikon info</string> | ||
| <string name="feedback_button_description">Kirim masukan tentang keterangan (tooltip) ini</string> | ||
| <string name="sponsor_button_description">Dukung kami melalui GitHub Sponsors</string> |
Contributor
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Use the cd_* convention for accessibility content descriptions.
As per coding guidelines, accessibility content descriptions must be stored using the cd_* prefix convention in strings.xml. Although this is a translation PR, please ensure these keys are renamed in the default strings.xml and their corresponding layout/Compose usages, and then update this translation file to match.
resources/src/main/res/values-in-rID/strings.xml#L842-L842: Rename thesponsor_button_descriptionstring key tocd_sponsor_button_description.resources/src/main/res/values-in-rID/strings.xml#L1224-L1278: Rename theundockandfloating_window_action_*string keys to use thecd_*prefix (e.g.,cd_undock,cd_floating_window_action_minimize).
📍 Affects 1 file
resources/src/main/res/values-in-rID/strings.xml#L842-L842(this comment)resources/src/main/res/values-in-rID/strings.xml#L1224-L1278
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@resources/src/main/res/values-in-rID/strings.xml` at line 842, Rename
sponsor_button_description to cd_sponsor_button_description in the default
strings, all layout/Compose references, and
resources/src/main/res/values-in-rID/strings.xml:842-842. Rename undock and
every floating_window_action_* key to the corresponding cd_* names in the
default strings, all usages, and
resources/src/main/res/values-in-rID/strings.xml:1224-1278, preserving the
translated values.
Source: Coding guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.