fix: look up a missing page object element once per wait attempt

src/main/java/io/appium/java_client/pagefactory/bys/builder/ByChained.java

@@ -16,11 +16,9 @@
 
 package io.appium.java_client.pagefactory.bys.builder;
 
-import io.appium.java_client.support.ui.FluentWait;
 import org.openqa.selenium.By;
 import org.openqa.selenium.NoSuchElementException;
 import org.openqa.selenium.SearchContext;
-import org.openqa.selenium.TimeoutException;
 import org.openqa.selenium.WebElement;
 
 import java.util.Optional;
@@ -70,10 +68,11 @@ public WebElement findElement(SearchContext context) {
         }
         requireNonNull(searchingFunction);
 
-        try {
-            return new FluentWait<>(context).until(searchingFunction);
-        } catch (TimeoutException e) {
+        // A single pass: the page object locator owns the wait and the timeout
+        WebElement result = searchingFunction.apply(context);
+        if (result == null) {
             throw new NoSuchElementException("Cannot locate an element using " + this);
         }
+        return result;
     }
 }

src/test/java/io/appium/java_client/pagefactory_tests/MissingElementLookupTest.java

@@ -0,0 +1,73 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * See the NOTICE file distributed with this work for additional
+ * information regarding copyright ownership.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package io.appium.java_client.pagefactory_tests;
+
+import io.appium.java_client.pagefactory.AndroidFindBy;
+import io.appium.java_client.pagefactory.AppiumFieldDecorator;
+import io.appium.java_client.pagefactory_tests.widget.tests.AbstractStubWebDriver;
+import io.appium.java_client.pagefactory_tests.widget.tests.StubWebElement;
+import org.junit.jupiter.api.Test;
+import org.openqa.selenium.By;
+import org.openqa.selenium.NoSuchElementException;
+import org.openqa.selenium.WebElement;
+
+import java.time.Duration;
+import java.util.ArrayList;
+import java.util.List;
+
+import static io.appium.java_client.support.PageFactory.initElements;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.lessThan;
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
+
+/**
+ * A page object field whose element is missing must be looked up once per attempt of the
+ * decorator's own wait, see https://github.com/appium/java-client/issues/2034.
+ */
+public class MissingElementLookupTest {
+
+    private static final class CountingAndroidDriver extends AbstractStubWebDriver.StubAndroidDriver {
+        private final List<String> lookups = new ArrayList<>();
+
+        @Override
+        public StubWebElement findElement(By by) {
+            if (!(by instanceof By.Remotable)) {
+                // like a remote driver, let a composite locator run its own lookups
+                return (StubWebElement) by.findElement(this);
+            }
+            lookups.add(by.toString());
+            throw new NoSuchElementException("Cannot locate " + by);
+        }
+    }
+
+    @AndroidFindBy(accessibility = "Not Exists")
+    private WebElement missingElement;
+
+    @Test
+    public void zeroTimeoutLooksUpMissingElementOnce() {
+        CountingAndroidDriver driver = new CountingAndroidDriver();
+        initElements(new AppiumFieldDecorator(driver, Duration.ZERO), this);
+
+        long start = System.nanoTime();
+        assertThrows(NoSuchElementException.class, () -> missingElement.click());
+        long elapsedMs = Duration.ofNanos(System.nanoTime() - start).toMillis();
+
+        assertEquals(List.of("AppiumBy.accessibilityId: Not Exists"), driver.lookups);
+        assertThat("A zero timeout should not wait", elapsedMs, lessThan(400L));
+    }
+}