This repository was archived by the owner on Nov 10, 2026. It is now read-only.
Repository navigation
fix: Rethrow boot errors other than the already booted state - #319
Merged
mykola-mokhnach merged 1 commit intoNov 6, 2026
Merged
Conversation
mykola-mokhnach
approved these changes
Nov 4, 2026
Contributor
|
@RaphaelFakhri could you please resolve conflicts? |
Contributor
Author
|
Rebased onto |
RaphaelFakhri
force-pushed
the
fix/boot-device-error-handling
branch
from
November 6, 2026 20:17
48d0ca4 to
767c9c6
Compare
github-actions Bot
pushed a commit
that referenced
this pull request
Nov 6, 2026
## [9.1.3](v9.1.2...v9.1.3) (2026-11-06) ### Bug Fixes * Rethrow boot errors other than the already booted state ([#319](#319)) ([80d6f37](80d6f37))
|
🎉 This PR is included in version 9.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bootDevice()had its error check inverted. It rethrew theUnable to boot device in current state: Bootederror, which it is meant to ignore, and silently swallowed every other failure, including invalid UDIDs, missing runtimes, timeouts and theudid is requirederror fromrequireUdid.The negation was lost when simctl was converted to a class in #97. The original handling rethrew any error that did not contain the already-booted message. This change restores that behavior, which also matches
shutdownDevice().Changes
lib/subcommands/boot.ts: rethrow unless the error is the already-booted error.test/unit/simctl.spec.ts: add#bootDeviceunit tests for a successful boot, the already-booted case, other boot errors, and an unset UDID.Testing
npm run build && npm test: 27 passed, 0 failed.npm run lintandnpm run format:checkare clean.Fixes #318