Skip to content

Negative encoding value crashes the decoder #6

Description

@nassersala

A file reference with a negative encoding traps instead of throwing:

let json = #"{"default-configuration":"Debug","localizations":{"development":"en"},"files":[{"path":"a.txt","encoding":-1}]}"#
_ = try XCSchema.Project(jsonRepresentation: Data(json.utf8))
// Fatal error: Negative value is not representable

xcprojformatter dies the same way (exit 133).

It's UInt(Int(with: coder)) in String.Encoding+JSONCodable.swift:107. Values above Int.max (e.g. 9223372036854775808) crash too, because NSNumber.intValue in Value.swift:94 wraps them negative. UInt(exactly:) plus a thrown error would fix it.

main @ c132630, macOS 26, Swift 6.3.3

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions