Enable more mypy and Pylint checks for test_tooling/#4620
Merged
Conversation
correctmost
commented
Jul 8, 2026
| def ensure_sudo(): | ||
| global sudo_password # pylint: disable=global-statement | ||
| @cache | ||
| def get_sudo_password() -> str: |
Contributor
Author
There was a problem hiding this comment.
One flaw with this code and the previous ensure_sudo code is that a mistyped password cannot be corrected after the first attempt is tried.
svartkanin
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description:
I think it's worthwhile to type check test code. This also makes it easier to run other type checkers on the codebase without configuring exclusions.
Tests and Checks