Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2730
What this changes
Moves every version declaration this repository keeps from 0.3.39 to 0.3.40 — the eight sources, in one
commit, so no installation can end up half-upgraded with one file naming a version another does not.
Why now
v0.3.39is tagged one6a5002c. Master has since advanced one commit:9220ac89, the self-media roundthat publishes once through the session this machine already holds. An installation upgrading today
receives nothing of it and reports the same version as one that lacks it, so two installations cannot be
told apart by the number that exists to tell them apart.
How it was verified
bump-version.py --checkis ameasurement of every declaration rather than one standing in for the rest:
OK: all 8 version sources agree on 0.3.40.tests/test_version_sync.py—3 passed.
tree that a suite was actually run against.
9220ac89is the commit this bump sits ontop of, not the branch that carried it.
What this does not do
It cuts no tag. A published tag cannot be withdrawn and pushing one fires the release build, so the gate
is explicit: this PR must be on master with CI concluded green on that exact merge commit before
check-release-tag.py v0.3.40is run and the annotated tag is pushed.