36 upgrade ruby jekyll - #62
Conversation
There was a problem hiding this comment.
Pull request overview
Updates repository documentation and CI to better support building the Jekyll site with a defined Ruby/Bundler/Jekyll toolchain, and adds an Actions workflow to validate builds on pushes and PRs.
Changes:
- Expanded README with Ruby/Bundler/Jekyll environment details and local build/serve steps.
- Added a GitHub Actions workflow to run
bundle exec jekyll buildon push/PR/manual dispatch.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README | Adds build environment and local build/preview instructions for the Jekyll site. |
| .github/workflows/jekyll-build.yml | Introduces CI workflow to validate that the site builds successfully with Bundler/Jekyll. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| - Ruby 3.4.10, selected by `.ruby-version` | ||
| - Bundler 2.6.9, recorded in `Gemfile.lock` | ||
| - Jekyll 4.4.1 or later within the `Gemfile` constraint |
adambuttrick
left a comment
There was a problem hiding this comment.
@jsjiang Looks good! Would we be able to add the explicit .ruby-version as well?
|
@adambuttrick Regarding the |
|
@jsjiang Thanks, Jing! I'm thinking it might be good for my local installation to run the exact ruby version as running on arks.org. That way things will be more predictable between local and the CDL-hosted site. OTOH, as long as the major Ruby version is documented (eg, README), I think I can make this work. I recall once having to upgrade my ruby version, but wasn't sure which version to go to. After upgrading, I had to update the gems, which altered Gemfile.lock file, and that made preparing PRs problematic. The main point (for me) of running the site locally is to edit the site docs and generate PRs regularly to update the public site. |
@adambuttrick Hi Adam,
I updated the readme with Ruby environment and jekyll build instructions. The
jekyll-build.ymlworkflow is to test jekyll build and will be triggered on push and pull request. Please review and let me know if you want to make adjustments.Thank you
Jing