Skip to content

36 upgrade ruby jekyll - #62

Merged
jsjiang merged 4 commits into
mainfrom
36_upgrade_ruby_jekyll
Aug 27, 2026
Merged

36 upgrade ruby jekyll#62
jsjiang merged 4 commits into
mainfrom
36_upgrade_ruby_jekyll

Conversation

@jsjiang

@jsjiang jsjiang commented Aug 26, 2026

Copy link
Copy Markdown
Collaborator

@adambuttrick Hi Adam,
I updated the readme with Ruby environment and jekyll build instructions. The jekyll-build.yml workflow is to test jekyll build and will be triggered on push and pull request. Please review and let me know if you want to make adjustments.

Thank you

Jing

@jsjiang
jsjiang requested review from adambuttrick and a lite review from Copilot August 26, 2026 23:42

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates repository documentation and CI to better support building the Jekyll site with a defined Ruby/Bundler/Jekyll toolchain, and adds an Actions workflow to validate builds on pushes and PRs.

Changes:

  • Expanded README with Ruby/Bundler/Jekyll environment details and local build/serve steps.
  • Added a GitHub Actions workflow to run bundle exec jekyll build on push/PR/manual dispatch.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
README Adds build environment and local build/preview instructions for the Jekyll site.
.github/workflows/jekyll-build.yml Introduces CI workflow to validate that the site builds successfully with Bundler/Jekyll.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README
Comment on lines +9 to +11
- Ruby 3.4.10, selected by `.ruby-version`
- Bundler 2.6.9, recorded in `Gemfile.lock`
- Jekyll 4.4.1 or later within the `Gemfile` constraint

@adambuttrick adambuttrick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsjiang Looks good! Would we be able to add the explicit .ruby-version as well?

@jsjiang

jsjiang commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator Author

@adambuttrick Regarding the .ruby-version file , I left it out on purpose. We will let the people who runs the Jekyll build to setup their won Ruby environment. All minor versions of Ruby 3.4 should work.

@jsjiang
jsjiang merged commit e9a8ce8 into main Aug 27, 2026
3 checks passed
@jkunze

jkunze commented Aug 30, 2026

Copy link
Copy Markdown
Collaborator

@jsjiang Thanks, Jing! I'm thinking it might be good for my local installation to run the exact ruby version as running on arks.org. That way things will be more predictable between local and the CDL-hosted site. OTOH, as long as the major Ruby version is documented (eg, README), I think I can make this work.

I recall once having to upgrade my ruby version, but wasn't sure which version to go to. After upgrading, I had to update the gems, which altered Gemfile.lock file, and that made preparing PRs problematic. The main point (for me) of running the site locally is to edit the site docs and generate PRs regularly to update the public site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants