Add resizable paged virtual keyboard with stable resize performance#3050
Draft
Shrookin wants to merge 2 commits into
Draft
Add resizable paged virtual keyboard with stable resize performance#3050Shrookin wants to merge 2 commits into
Shrookin wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a resizable, paged virtual keyboard and keeps resizing responsive when a layout contains more rows than the selected height can display.
Why
While dragging the resize handle, each pointer movement previously recalculated paging. That work repeatedly forced layout reads (
scrollHeightandoffsetHeight), removed and reapplied row visibility classes, and changed the space occupied by the paging controls. The result was visible key churn, jitter, and poor frame rates during resizing.Changes
Compatibility
The existing
setUserHeight()andpageRows()behavior remains available. The user-height persistence used by the Skillboard website is intentionally not included here; it remains website-specific and is not part of MathLive's core API.Validation
npx tsc --noEmitnpm run build(0 build errors; existing documentation-link warnings only)npx playwright test test/playwright-tests/virtual-keyboard.spec.ts --project=chromium(6 passed)