fix: use aggregate read_action instead of using relationship read#239
Open
averypeck wants to merge 1 commit into
Open
fix: use aggregate read_action instead of using relationship read#239averypeck wants to merge 1 commit into
averypeck wants to merge 1 commit into
Conversation
7 tasks
averypeck
marked this pull request as ready for review
July 18, 2026 02:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ash.Query.Aggregate.new/4 accepts a
read_actionparameter: https://ash.hexdocs.pm/Ash.Query.Aggregate.html#new/4, validates it, and sets it on the aggregate.query that it passes to ash_sql. ash_sql ignores that read_action and derives it again from the the relationship:ash_sql/lib/aggregate.ex
Line 168 in 35c712f
This PR adds an "override" for resolving the specified read_action on the last relationship in the relationship path for the aggregate. Failing regression tests on this ash_postgres PR provide a reproduction.
Contributor checklist
Leave anything that you believe does not apply unchecked.