Repository navigation
ENG-37: Add pull_request CI workflow (Ruff gate, then pytest on 3.11) - #4
Merged
asinglesprinkle merged 2 commits intoAug 3, 2026
Conversation
Forman had no CI, so a pull request carried no automated signal. This adds .github/workflows/ci.yml, triggered only on pull_request with GitHub's default activity types. Two jobs on ubuntu-latest, both pinned to Python 3.11 (the declared floor in requires-python, even though local venvs run 3.14): a lint job running `ruff check` then `ruff format --check`, and a test job gated on it via `needs:`, so a lint failure means pytest never runs. Splitting them gives two distinct check names in the PR UI. pytest is invoked bare; testpaths and pythonpath in pyproject handle discovery of the src-layout package. The suite is hermetic and the only runtime dependency comes from PyPI, so the workflow needs no secrets. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
asinglesprinkle
deleted the
eng-37/add-pull-request-ci-workflow-for-forman-ruff-gate
branch
August 3, 2026 03:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a net-new
.github/workflows/ci.ymlso every pull request gets an automated pass/fail signal.on:contains onlypull_request, with GitHub's default activity types (opened, synchronize, reopened).ubuntu-latest: Lint (ruff check, thenruff format --check) and Test (pytest) withneeds: lint, so pytest never runs if the lint gate fails.actions/setup-python@v5pinned to a single literal'3.11'— no matrix.pip install -e ".[dev]". No secrets referenced.Opened as a no-op PR to verify the workflow runs green and re-runs on subsequent commits. Not intended to be merged as part of the verification step; branch protection / required checks are explicitly out of scope.
🤖 Generated with Claude Code