Repository navigation
Conversation
zanieb
added
arch:x86_64
build:pgo
libc:gnu
platform:linux
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPython copies its perf trampoline into executable memory at runtime. With the template in
.text, BOLT can instrument it or move its start and end markers independently, making the copied trampoline invalid. The padding byte and trampoline-specific exclusion added in #1356 avoid this failure.Store the template in
.rodatafor BOLT-enabled builds so BOLT treats it as data, replacing both workarounds. Remove the BOLT-specific skips fromtest_perf_profilerfor these builds.Follows the approach proposed in python/cpython#160366.