Repository navigation
feat: implement syncBuffer for concurrent log writing in tests - #1751
Merged
Merged
Conversation
ramya18101
marked this pull request as ready for review
November 4, 2026 05:27
bkiran6398
approved these changes
Nov 4, 2026
duedares-rvj
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Fixes a data race in the
it keeps the log ID cursor when polling with a filtersubtest ofTestTailLogsCommand(added in #1723), which madego test -racefail intermittently in CI.Replicated:
📚 References
--filter)🔬 Testing
go test -race ./internal/cli/ -run TestTailLogs -count=30
All 30 runs passed with the race detector enabled.
📝 Checklist