fix: correct the derivedSectorIdentifier JavaDoc null condition - #172
Open
watahani wants to merge 1 commit into
Open
fix: correct the derivedSectorIdentifier JavaDoc null condition#172watahani wants to merge 1 commit into
watahani wants to merge 1 commit into
Conversation
The JavaDoc said the value is undefined when no sector_identifier_uri is registered and multiple redirect_uris are registered. The value is null only when the registered redirect_uris do not yield a single host component, and it is null rather than undefined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JavaDoc-only change on
Client#getDerivedSectorIdentifier/#setDerivedSectorIdentifier.The old text said the value is undefined when no
sector_identifier_uriis registered and multipleredirect_uris are registered. The value isnull(not undefined) only when the registered redirect URIs do not yield a single host component, so several redirect URIs sharing one host do produce a value. The two othernullcases — no redirect URI registered, and a redirect URI with no host component such ascom.example.app:/callback— are now stated as well.The value is computed server-side by
ClientEntity.deriveSectorIdentifier(): ifsectorIdentifierUriis set its host component is used, otherwise the host components of all registered redirect URIs are collected into aSetand returned only when exactly one distinct value remains.The same wording is corrected in the API Docs specs (
authlete/new-api-doc!192) and in the server-side JavaDoc (authlete/server!2527).Review
No sub-agent review loop was run: the 3-loop pre-merge rule covers MRs against the support skills repo, and this is a comment-only change.
Ref: ClickUp CU-86eyuyzwj