Repository navigation
fix: lock two caches in address order in __eq__ and __ne__ - #122
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #118:
__eq__/__ne__lockedselfand thenother, soa == bon one thread andb == aon another could each hold one lock and wait for the other. They now take both locks throughWrapped::policy_pair_py_attached, which always locks the two caches in address order.test_compare_with_arguments_swappedrunsa == b/a != bandb == a/b != aon two threads in a child process, with keys whose__eq__is Python code so the threads switch while the locks are held.main(run): it hangs for all 7 classes on ubuntu 3.10–3.15, 3.14t and pypy3.11, and for some of them on macos, windows and 3.15t.update()from the same issue is not in this PR; I described why there in the issue.