Repository navigation
Add optimizer-owned gradient clipping extension point - #10
Draft
ryan-li-ryanllli-aws wants to merge 1 commit into
Draft
ryan-li-ryanllli-aws wants to merge 1 commit into
ryan-li-ryanllli-aws wants to merge 1 commit into
Conversation
ryan-li-ryanllli-aws
force-pushed
the
ryanllli/compiled-grad-clip-extension
branch
2 times, most recently
from
October 14, 2026 18:05
376ea8e to
2f7c6ae
Compare
ryan-li-ryanllli-aws
force-pushed
the
ryanllli/compiled-grad-clip-extension
branch
from
October 14, 2026 18:11
2f7c6ae to
aec3a81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GradientClipperinterface owned by the optimizer componentOptim.Config.gradient_clipperand build it once for the optimizer lifetimeMotivation
Gradient clipping operates on optimizer-owned mutable gradient state, but there
was no scoped component seam for a private device backend to provide its own
implementation. This change makes that behavior explicit in optimizer
configuration without replacing the eager utility process-wide.
The private device backend implementation remains outside TorchTitan core.
User story: integrate a private device backend
A private device backend has its own gradient clipping implementation,
including any compile support it needs. Its integration package supplies a
concrete
GradientClippercomponent and opts in through optimizerconfiguration:
The optimizer constructs the configured component once and uses the same
dispatch from its standard and specialized update paths. When no component is
configured, the existing eager gradient clipping behavior is unchanged.
Testing
SKIP=pyrefly-check pre-commit run --all-filesThe added unit tests were not executed locally because the available
environment does not contain the repository's current dependency set. They are
included for execution in an environment with that stack.