Repository navigation
Conversation
powertools-for-aws-oss-automation
Bot
added
the
size/L
|
Author
|
Hi, I accidentally removed my assignment from this PR and now GitHub doesn't show me an option to assign myself again. I'm still actively interested in maintaining this contribution. Could a maintainer please reassign me (@Suraj1347) to PR #8623? Thank you! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #8594
Summary
When raise_on_error=False, parameter transformation failures in get_parameters_by_name should be reported gracefully instead of unexpectedly raising an exception or caching a failed result.
Changes
Handle TransformParameterError in the decrypt and batch retrieval paths when graceful error handling is requested.
Record failed parameter names in _errors.
Omit failed batch transformations from the returned mapping and avoid caching failed results.
Preserve fail-fast behavior when raise_on_error=True.
Correctly handle valid JSON null values without treating them as transformation failures.
Tests and verification
Targeted get_parameters_by_name tests: 22 passed.
Full test_utilities_parameters.py: 130 passed.
Ruff check: passed.
Ruff format check: passed.
These checks were run locally. GitHub CI and maintainer review remain pending.
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.