feat(project): add CDK Toolkit adapter - #2057
Merged
Merged
Conversation
notgitika
had a problem deploying
to
e2e-testing
August 20, 2026 03:12 — with 
GitHub Actions
Failure
GitHub Actions
Failure
This was referenced Aug 20, 2026
github-actions
Bot
added
agentcore-harness-reviewing
notgitika
marked this pull request as ready for review
August 20, 2026 04:12
notgitika
force-pushed
the
feat/project-cdk-toolkit
branch
from
August 20, 2026 04:19
a3da8e2 to
000e3b8
Compare
notgitika
marked this pull request as draft
August 20, 2026 04:19
notgitika
had a problem deploying
to
e2e-testing
August 20, 2026 04:19 — with
GitHub Actions
Failure
GitHub Actions
Failure
notgitika
marked this pull request as ready for review
August 20, 2026 04:24
notgitika
force-pushed
the
feat/project-cdk-toolkit
branch
from
August 20, 2026 17:06
000e3b8 to
ef1f731
Compare
notgitika
had a problem deploying
to
e2e-testing
August 20, 2026 17:07 — with
GitHub Actions
Failure
GitHub Actions
Failure
tejaskash
reviewed
Aug 21, 2026
notgitika
force-pushed
the
feat/project-cdk-toolkit
branch
from
August 21, 2026 16:01
ef1f731 to
c4723b3
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2057 +/- ##
=========================================
Coverage 97.25% 97.26%
=========================================
Files 397 398 +1
Lines 24125 24192 +67
=========================================
+ Hits 23463 23530 +67
Misses 662 662 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
notgitika
force-pushed
the
feat/project-cdk-toolkit
branch
from
August 21, 2026 16:16
c4723b3 to
6c52205
Compare
notgitika
force-pushed
the
feat/project-cdk-toolkit
branch
from
August 21, 2026 17:41
6c52205 to
8b9d408
Compare
tejaskash
reviewed
Aug 21, 2026
tejaskash
reviewed
Aug 21, 2026
notgitika
force-pushed
the
feat/project-cdk-toolkit
branch
from
August 21, 2026 18:12
8b9d408 to
33e58a0
Compare
notgitika
force-pushed
the
feat/project-cdk-toolkit
branch
from
August 21, 2026 18:21
33e58a0 to
d5e69ff
Compare
notgitika
force-pushed
the
feat/project-cdk-toolkit
branch
from
August 24, 2026 14:59
d5e69ff to
5cc76e5
Compare
PATTERN_MUST_MATCH_SINGLE throws unless the pattern matches exactly one
stack, so an absent result was never "no match". The Toolkit skips a
stack whose synthesized template has no resources, and deletes it if a
stack of that name already exists — both return normally with no stacks.
`?? {}` turned that into a successful deploy with no outputs, so a caller
expecting RuntimeArn got undefined with nothing explaining why.
Assert exactly one stack and name both possibilities in the error,
keeping `?? {}` only for a stack that deployed but declares no outputs.
Both paths are now covered; the fake toolkit takes the stack list so the
resource-less case is reachable from a test.
Also narrows the `external` comment in scripts/build.ts: it describes the
npm bundle only. compile() cannot mark the Toolkit external because a
standalone binary ships no node_modules, so Bun inlines it and rewrites
__dirname to the build machine's path — which resolves on the builder and
fails everywhere else.
notgitika
force-pushed
the
feat/project-cdk-toolkit
branch
from
August 24, 2026 16:01
5cc76e5 to
9750c4e
Compare
tejaskash
approved these changes
Aug 24, 2026
Hweinstock
approved these changes
Aug 24, 2026
| } | ||
|
|
||
| /** Loads the Toolkit only when a deploy operation needs it. */ | ||
| export const loadCdkToolkit: CdkToolkitLoader = async (ioHost, region) => { |
Contributor
There was a problem hiding this comment.
I like how this is loaded lazily.
Contributor
Author
There was a problem hiding this comment.
yeah I had my agent test the latency with the static import and it was quite a bit higher. thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@aws-cdk/toolkit-libStack
This is PR 3 of 4 decomposing #2001. The adapter is backend-local rather than part of shared
io. Review and merge bottom-up.typecheck, lint, format, test all pass