fix: honor language defaults for BYO agents - #2081
Open
nanookclaw wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2075
add agent --type byo --language TypeScriptcurrently persists the Python runtime and entrypoint, so the documented TypeScript BYO path later selects the wrong packager. This updates the BYO mapping to use the existing language default maps: TypeScript now persistsNODE_22andmain.jswhen no entrypoint is supplied. Python andOtherretain their existingPYTHON_3_14/main.pybehavior, and explicitly supplied entrypoints remain unchanged.The focused add-agent regression coverage verifies persistence for TypeScript, Python, and
Other.git diff --checkpassed. The local checkout did not include the npm toolchain, andnpxcould not reach the registry (EAI_AGAIN), so the Vitest, TypeScript, and Prettier checks could not run locally.