-
Notifications
You must be signed in to change notification settings - Fork 85
feat(dev): wire the Agent Inspector into project dev #2086
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6490abd
b5c9d54
de37308
9302619
250d57d
123f0b9
66aecaf
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,7 +26,19 @@ export async function resolveDevPort( | |
| checkPort: PortChecker, | ||
| signal: AbortSignal, | ||
| ): Promise<DevPort> { | ||
| const defaultPort = DEV_PORTS[protocol ?? "HTTP"]; | ||
| return findFreePort(DEV_PORTS[protocol ?? "HTTP"], explicitPort, checkPort, signal); | ||
| } | ||
|
|
||
| /** | ||
| * Resolve a free port from `defaultPort`. An explicit port must be free or the | ||
| * call fails; otherwise the next free port from the default up is taken. | ||
| */ | ||
| export async function findFreePort( | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. just a question, certain protocols reserve a port right? if that port is busy, are we still finding a new port for them?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yep, we scan for the next free port unless you pass an explicit |
||
| defaultPort: number, | ||
| explicitPort: number | undefined, | ||
| checkPort: PortChecker, | ||
| signal: AbortSignal, | ||
| ): Promise<DevPort> { | ||
| const requestedPort = explicitPort ?? defaultPort; | ||
|
|
||
| if (await checkPort(requestedPort, signal)) { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im confused why did we change this method name? isnt it still extracting from SSE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm I see this comment in the previous PR #2085 (comment)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, it only handles A2A event kinds, so the generic SSE name was misleading.