feat(release): auto-bump the vended CDK pin during release prep - #2118
Merged
Conversation
jariy17
force-pushed
the
tj/autobump-vended-cdk-release
branch
from
August 26, 2026 21:23
d5b045b to
9668a16
Compare
jariy17
marked this pull request as ready for review
August 26, 2026 21:25
Contributor
Package TarballHow to installgh release download pr-2118-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.28.0.tgz |
Contributor
Coverage Report
|
jariy17
force-pushed
the
tj/autobump-vended-cdk-release
branch
from
August 26, 2026 22:17
9668a16 to
104bd89
Compare
Adds scripts/sync-vended-cdk.ts, which resolves @aws/agentcore-cdk from an npm dist-tag (or an explicit --to) and rewrites the pin in the vended CDK template, and wires a 'Sync vended CDK version' step into the active release workflow (release-main-and-preview.yml) before its existing snapshot-update step. The bump now rides into the reviewed release PR instead of a separate hand-edited PR per prerelease (see #2087). Tag is configurable via the new cdk_dist_tag input (default: latest); the step is a no-op when the template is already current. Depends on the pin de-duplication in the parent commit: because the dependency-management tests derive the pin from the template, this bump needs no test edits.
aidandaly24
force-pushed
the
tj/autobump-vended-cdk-release
branch
from
August 27, 2026 14:51
104bd89 to
316b0bd
Compare
aidandaly24
had a problem deploying
to
e2e-testing
August 27, 2026 14:52 — with
GitHub Actions
Failure
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
aidandaly24
temporarily deployed
to
e2e-testing
August 27, 2026 14:57 — with
GitHub Actions
Inactive
aidandaly24
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop hand-editing the
@aws/agentcore-cdkpin every prerelease (ddb32a2 / #2087).What changed (2 files)
scripts/sync-vended-cdk.ts— resolves the target fromnpm view @aws/agentcore-cdk@<tag>(or explicit--to <version>), rewrites the template pin, no-op if already current.--dry-runsupported..github/workflows/release-main-and-preview.yml:cdk_dist_taginput (defaultlatest— the only dist-tag@aws/agentcore-cdkpublishes).prettier --write; the existing snapshot step refreshes the.snap. The bump rides the release PR the workflow already opens.Targets the workflow you actually dispatch (
release-main-and-preview.yml), not the unusedrelease.yml.Verified end-to-end
Ran the real workflow in a private mirror of this repo (GitHub-hosted runners,
npm publishstubbed). With the template baselined atalpha.48, the release run auto-produced a PR whose diff is exactly:Sync step + snapshot refresh: green. No test edits needed (tests derive the pin from #2117).
Why safe
The bump lands in the auto-created release PR, which already requires human review and a manual npm-publish approval gate. Nothing auto-publishes. The step is idempotent — a no-op when the pin is already current.