chore: update aurora initial connection strategy plugin implementation - #1253
Open
karenc-bq wants to merge 1 commit into
Open
chore: update aurora initial connection strategy plugin implementation#1253karenc-bq wants to merge 1 commit into
karenc-bq wants to merge 1 commit into
Conversation
sophia-bq
reviewed
Jun 23, 2026
| "AuroraInitialConnectionStrategyPlugin.InvalidSettingForEndpoint", | ||
| WrapperProperties.VERIFY_OPENED_CONNECTION_ROLE.name, "writer", "reader cluster or custom cluster")) | ||
|
|
||
| def _get_candidate_host( |
Contributor
There was a problem hiding this comment.
Is accessible region filtering planned for here as well?
Contributor
Author
There was a problem hiding this comment.
not in this PR, will be in the GDB PR
Comment on lines
+370
to
+372
| # SUBSTITUTE_WITH_ANY has no specific target role; default to READER for host selection, | ||
| # mirroring the JDBC behavior where the selector treats a null role as "any". | ||
| selection_role = target_role if target_role is not None else HostRole.READER |
Contributor
There was a problem hiding this comment.
Hmm I'm confused shouldn't substitute with any also accept a writer?
karenc-bq
force-pushed
the
chore/initial-strategy-plugin
branch
from
August 4, 2026 23:20
7d32685 to
24a4316
Compare
karenc-bq
marked this pull request as ready for review
August 4, 2026 23:34
karenc-bq
force-pushed
the
chore/initial-strategy-plugin
branch
from
August 4, 2026 23:53
24a4316 to
86db9c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.